Conversation
Fixes #6. The module was declared as `module gopacket` in go.mod, which is not a canonical import path. External projects could not `go get github.com/mandiant/gopacket` to use any of the 24 protocol packages as a library; the only workaround was to clone the repo and add a `replace` directive to their own go.mod. This commit: - Sets `module github.com/mandiant/gopacket` in go.mod. - Rewrites 434 import statements across 157 files from the bare `gopacket/...` prefix to `github.com/mandiant/gopacket/...`. Pure mechanical change, no behavior difference. Makes the README's library story (pkg/ directory, 24 reusable packages) actually usable from external code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6 (thanks @5amu for flagging).
The module was declared as
module gopacketingo.mod, which is not a canonical import path. External projects could notgo get github.com/mandiant/gopacketto use any of the 24 protocol packages as a library; the only workaround was to clone the repo and add areplacedirective to their owngo.mod. This change makes the README's library story actually usable from external code.Changes
go.mod:module gopacket→module github.com/mandiant/gopacket"gopacket/..."→"github.com/mandiant/gopacket/..."Pure mechanical change, no runtime or behavior difference.
pkg/third_party/smb2imports are covered by the same sweep since the vendored code uses the host module path internally.Test plan
go mod tidycleango build ./...cleango vet ./...cleango test ./pkg/transport/passes (test output shows the newgithub.com/mandiant/gopacket/pkg/transportpath, confirming the rename took)