Repository navigation
Replace the editor with a notation-first test workbench - #2
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 33565350c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const numberVars = projection.value.available_vars.filter( | ||
| variable => variable.value_type === 'number' && variable.node_kind === 'scalar', | ||
| ); |
There was a problem hiding this comment.
Move this eligibility predicate into the Rust projection instead of interpreting the generic available_vars list in the view. When SumBound eligibility changes or becomes context-dependent, this duplicate TypeScript rule can hide valid targets or offer illegal ones before the Rust action rejects them; the component should only render action-specific candidates projected by the domain layer.
AGENTS.md reference: AGENTS.md:L11-L15
Useful? React with 👍 / 👎.
| if ((event.metaKey || event.ctrlKey) && event.key.toLowerCase() === 'z') { | ||
| event.preventDefault(); | ||
| if (event.shiftKey) redoDocument(); | ||
| else undoDocument(); |
There was a problem hiding this comment.
When focus is inside a name, constraint, or seed input, this window-level handler still prevents the browser's native Ctrl/Cmd+Z and instead undoes the latest AST action. For example, typing a new node name and pressing Ctrl+Z can remove the previously created node rather than undoing the typed characters; ignore shortcuts originating from editable controls before dispatching document history.
Useful? React with 👍 / 👎.
Summary
Depends on manabeai/cp-ast-ecosystems#5
Verification
npm run lintnpm run test:unit(20 tests)npm run test:e2e(64 tests)npm run buildcargo test --workspaceand strictcargo clippy --workspace --all-targets -- -D warningsfrom a clean checkout