Fix tagged release publishing flow - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent
electron-builderfrom implicitly publishing whennpm run build:winruns from a Git tag.The v1.1.0 release workflow successfully built the installer but failed because electron-builder detected the tag and attempted its own GitHub publish before the workflow's checksum/release steps. The build step intentionally has no
GH_TOKENbecause publishing is handled explicitly later bygh release.Change
--publish nevertobuild:winVerification
git diff --check✅After merge, the existing unpublished
v1.1.0tag will be moved to the final commit and the release workflow will be re-triggered.