Repository navigation
fix: enforce Network and SMB1 Restore contracts - #63
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tighten selected-network and SMB1 legacy snapshot/Restore contracts so only baselines the tool can legitimately create and exactly restore are accepted.
Gaps reproduced before this fix
Restore validation accepted tampered snapshots with:
PrivateDomainAuthenticatedUnknownEnabledThe Windows SMB feature state enum on the live Windows 11 audit host also includes
DisablePending,Superseded,PartiallyInstalled, andDisabledWithPayloadRemoved. The current Restore logic cannot guarantee exact rollback for those states.Fix
PublicbaselinePublicbaselineDisabledbaselineDisabledfor the legacy enable actionEnabled/EnablePendingremain no-op states that preserve Restore historyUnknown,DisablePending,Superseded,PartiallyInstalled, andDisabledWithPayloadRemovedabort before snapshot/mutation because exact rollback is not guaranteedRegression coverage
Adds
tests/NetworkSmbRestoreContractSmoke.ps1covering:Local Windows PowerShell 5.1 verification
Normal Safe Repair behavior is unchanged; invalid or non-restorable baselines are rejected more strictly.