Repository navigation
fix: enforce firewall Restore action contract - #62
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tighten Restore validation for firewall Safe Repair snapshots so tampered or impossible firewall action state cannot reach mutation.
Gaps reproduced before this fix
Restore validation accepted:
Enable sharing firewall rulessnapshot with zero firewall entriesEnable sharing firewall rulessnapshot containing only a Public-profile sharing ruleNormal Safe Repair does not mutate Public-only rules, so those snapshots were outside the action's real mutation contract.
Fix
Regression coverage
Adds
tests/FirewallRestoreContractSmoke.ps1covering:Local Windows PowerShell 5.1 verification
The normal firewall repair surface is unchanged; invalid Restore input is rejected more strictly.