Repository navigation
fix: narrow combined Safe Repair snapshot scope - #61
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make combined Safe Repair snapshots contain only the service and firewall state the action actually plans to mutate.
Bugs reproduced before this fix
With real
New-RestoreSnapshotoutput:FPS-Ready,FPS-Fixwhile onlyFPS-Fixneeded repairSpooler,fdPHost,FDResPubwhile onlySpoolerwould be changed when discovery services were already RunningThat allowed later Restore to roll back managed state the combined action had never changed.
Fix
Spoolerin its service snapshot because Spooler is always restartedfdPHost/FDResPubare included only when they are not already RunningEnabled=True+ Domain/PrivateRegression coverage
Adds
tests/CombinedSafeRepairScopeSmoke.ps1covering:Local Windows PowerShell 5.1 verification
No Safe Repair capability is removed; snapshot scope is made exact.