geoprobe-agent: filter cached DZD measurements to avoid jittery measurements#3309
Open
geoprobe-agent: filter cached DZD measurements to avoid jittery measurements#3309
Conversation
nikw9944
approved these changes
Mar 23, 2026
Replace the single-entry-per-sender offset cache with a two-slot (best + backup) structure. The best slot holds the lowest RTT seen in the full maxAge window, while the backup slot holds the lowest RTT from the recent half-maxAge interval. When the best expires, the backup is promoted, preventing latency spikes from losing a good measurement. Fixes #3219
02b48e6 to
35c94fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #3219
Summary of Changes
bestslot holds the lowest RTT offset across the full validity window;backupholds the lowest RTT from the recent half-window, ensuring a smooth handoff whenbestexpiresDiff Breakdown
Compact change — ~50 net lines of core logic, well-covered by 7 new test cases.
Key files (click to expand)
controlplane/telemetry/cmd/geoprobe-agent/main.go— newcachedSenderstruct withbest/backupslots; rewrittenPut()with RTT filtering and backup promotion,Get()with fallback to backup,GetBest()iterating both slots,Evict()checking both slotscontrolplane/telemetry/cmd/geoprobe-agent/main_test.go— 7 new tests (PutKeepsBest, PutLowerRTTReplacesBest, BackupPromotion, BackupRefreshInHalfWindow, GetBestWithTwoSlots, EvictBothSlots) + updated PutReplaces expectationTesting Verification
go test -v -count=1 ./controlplane/telemetry/cmd/geoprobe-agent/...)