smartcontract: allow feed authority to operate on non-owned access passes#3298
Draft
smartcontract: allow feed authority to operate on non-owned access passes#3298
Conversation
…sses Remove ownership checks that restricted the feed authority to only modify or update access passes it created. The feed authority needs to manage access passes created by other authorities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Diff Breakdown
Mostly removing restriction code and updating tests to verify non-owner operation.
Key files (click to expand)
smartcontract/.../accesspass/set.rs— remove ownership check on SetAccessPass updatessmartcontract/.../subscriber/add.rs— remove ownership check on subscriber allowlist modificationssmartcontract/.../multicastgroup_allowlist_subcriber_test.rs— update tests so feed authority operates on access passes it doesn't ownTesting Verification