Repository navigation
Fix inherited association selection and UTF-8 config loading - #48
Open
shirohacker wants to merge 2 commits into
Open
shirohacker wants to merge 2 commits into
shirohacker wants to merge 2 commits into
Conversation
Use the MAL Toolbox subtype check to include child assets in association choices. Prevent accepting an empty choice and cover inherited endpoints in both directions with pytest.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 1 — Read saved MAL language path as UTF-8 (1d08505)
MAL-GUI wrote config.ini as UTF-8 but read it using the platform default encoding. It now reads the file as UTF-8, so saved language paths containing non-ASCII characters load correctly.
Commit 2 — Fix association selection for inherited asset types (78dd477)
The connection dialog required an exact match with an association’s declared endpoint types. In vehicleLang, this prevented InfotainmentSystem and OperatingSystem from connecting through the machineExecution association inherited from Machine and VehicularApplication. The dialog now accepts child asset types in either direction and disables OK when no association is available. Regression tests cover both behaviors.