Repository navigation
fix(release): the bump moves uv.lock with the version - #67
Merged
Merged
Conversation
pyproject.toml holds the version statically, so uv.lock records it too, and
bump_version.py moved only pyproject.toml and __init__.py. On 2026-10-17 the
first bump since uv.lock arrived, 2026.47, was refused by Quality ("The
lockfile at uv.lock needs to be updated") and the lock was moved by hand on
its branch.
update_lock moves the project's own entry and nothing that only shares the
number, the bump commits uv.lock, and a test holds the lock to the version
pyproject.toml states, so the suite bump_version.py runs after writing the
version refuses a bump that leaves it behind.
Red: 5 failed, green: 71 passed across the release tests; ruff, mypy clean.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Merging this PR will not alter performance
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyproject.tomlholds the version statically, souv.lockrecords it too, andbump_version.pymoved onlypyproject.tomland__init__.py. On 2026-10-17 the first bump sinceuv.lockarrived, #66 (2026.47), was refused by Quality:#66 got the lock line by hand, checked with uv 0.12.18, Quality's version. This makes the script do it.
update_lockmoves the project's own[[package]]entry, nothing that only shares the number, and keeps the line endings.BUMPED_FILES(what the bump commits) includesuv.lock.main()calls it after the other two, before the suite.test_the_lock_carries_the_version_pyproject_statesholds the real lock to the real version, so the suitebump_version.pyruns after writing the version refuses a bump that leaves the lock behind, on this machine, before any commit.TDD: red, 5 failed (the two
main()sequences and threeTestLockcases); green, 71 passed acrosstest_bump_version,test_release_through_pr,test_release_script_encoding. ruff and mypy clean.Only patchradar is affected: the other five have
dynamic = ["version"]and their locks carry no version for the project.CHANGELOG: under [Unreleased], since 2026.47 is already on its way.
🤖 Generated with Claude Code