This repository was archived by the owner on Aug 7, 2021. It is now read-only.
Change when progress begins and ends, option to hide progress bar, update dependencies#4
Open
petekeller2 wants to merge 11 commits intomakotot:masterfrom
Open
Change when progress begins and ends, option to hide progress bar, update dependencies#4petekeller2 wants to merge 11 commits intomakotot:masterfrom
petekeller2 wants to merge 11 commits intomakotot:masterfrom
Conversation
The following is for when there is a target element. Progress will begin once the top of the viewport hits the top of the target element. Progress will end once the bottom of the viewport hits the bottom of the target element.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Change when progress begins and ends (See: f066177)
Updates: Update the dependencies
Updates: Update the first test
New Feature: Option to hide progress bar if progress is 0 or max (Use case: Article text is between a large image and a comment section)