fix(cindy-make): 完善个人版制作、测试与失败恢复流程 - #4778
Conversation
Unify source preparation and history presentation, confirm upstream conflicts, restore unbuilt integrations safely, and keep native task attention in sync. Preserve test profiles while reclaiming preview processes and temporary files. Reuse packaged node-pty prebuilds and validate inherited migration history for tag checkouts. Signed-off-by: MagicLizi <jiali@magiclizi.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
|
独立审查完成,当前提交 f5ae7a0 未发现剩余 P0/P1。审查中发现的 release/beta 标签克隆缺少本地 main 导致构建失败已修复,并经真实 Git 测试验证。 本地提交前门禁和对齐最新 main 后的复测均通过:相关单测、Desktop 类型检查、DCO、五语文案、设计颜色与台账检查;个人版构建/数据库定向复测 60 项通过。缺少 semgrep,未声称专项静态扫描已通过。 UI 说明:尚未附最终截图或录屏,Light/Dark 实机目检和 macOS/Linux 实机验证仍待补充;现有真实语言资源渲染测试通过。两处 rounded-xl 均属于 DESIGN §5 的内容容器/对话框 12px 分类,不构成视觉违规。 |
Keep workspace leases and temporary files until a real PTY exit, but return a bounded stopFailed result so editing and generation cannot wait forever. Surface the actionable error in all Cindy Make entry points and remove the pre-existing startup timing guard. Signed-off-by: MagicLizi <jiali@magiclizi.com>
POSIX process-group SIGKILL can return EPERM. Try the owned PTY process next so a failed group signal still has a chance to produce onExit, instead of only timing out the caller. Signed-off-by: MagicLizi <jiali@magiclizi.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 780c32e13e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: MagicLizi <jiali@magiclizi.com>
Signed-off-by: MagicLizi <jiali@magiclizi.com>
Signed-off-by: MagicLizi <jiali@magiclizi.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca5a2a8b19
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: MagicLizi <jiali@magiclizi.com>
There was a problem hiding this comment.
💡 Codex Review
cindy/apps/desktop/src/main/cindy-make/versionStore.ts
Lines 155 to 158 in a9686f6
当前保护只扫描带 version.json 的托管版本;当被构建源码未声明启动协议时,retainPersonalVersion() 会返回 undefined,但 personalBuild.ts 仍保留已验证的安装包并将本轮视为已发布。若进程随后在 recordHistoryBuild() 前退出,下一次构建又在进入 builder 前失败,recoverHistoryBuildRollback(true) 仍会把该成功安装包对应的集成判为未生成并撤回。相较已有评论,新的证据是本次新增的扫描仍未覆盖明确支持的旧源码“查看安装包”路径;需要为这类成品留下可恢复的发布标记,或让回滚同时识别其持久化产物。
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
这次改了什么
摘要
完善 Cindy Make 从准备源码、确认官方更新冲突、启动隔离测试版到生成个人版的完整流程。解决生成失败后个人源码残留合入、测试窗口关闭后进程未回收、Windows 打包强制重编 node-pty 失败,以及制作结果、版本对比和任务提醒不一致的问题;同时修复从 release/beta 标签克隆时缺少本地 main 导致的构建失败。
变更类型
范围
UI 变化
怎么验证的
自动验证
手工验证
Windows x64:此前用共用打包脚本成功生成版本无关安装包;本轮补跑该产物启动冒烟通过。使用产物中 node-pty 的预编译文件,在 Electron 41.10.3 下验证三个 binding 加载和真实 PTY 命令执行通过。该证据验证预编译件可用性,不代表本 PR 全部界面经过实机验收。
未执行的验证
macOS/Linux 实机打包、双主题实机目检和手机端到端未执行。未新增依赖,依赖漏洞扫描不适用;本机未安装 semgrep,专项静态扫描未执行。
风险
风险分类
影响与回滚
提交前检查