Skip to content

test(desktop): cover new-session model selection regression #4014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MagicLizi merged 1 commit into from
Sep 20, 2026
Merged

test(desktop): cover new-session model selection regression #4014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions apps/desktop/src/renderer/__tests__/chatInputModelSelectorRouting.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,29 @@ describe('ChatInput model source switching wiring', () => {
);
});

it('keeps a new conversation model pick on the draft path', () => {
const draftStart = chatInputSource.indexOf('const handleUnifiedDraftSelect = useCallback(');
const draftEnd = chatInputSource.indexOf(
'[sessionId, settingsLocked, modelMemory, onUnifiedDraftSelect]',
draftStart,
);
const draftHandler = chatInputSource.slice(draftStart, draftEnd);

expect(draftHandler).toContain('if (sessionId || settingsLocked) return;');
expect(draftHandler).toContain('onUnifiedDraftSelect?.({');
expect(draftHandler).not.toContain('maker.setModel(');
expect(draftHandler).not.toContain('confirmModelSwitchContextGuard(');

const selectorStart = chatInputSource.lastIndexOf('<ModelSelector');
const selectorBlock = chatInputSource.slice(
selectorStart,
chatInputSource.indexOf('/>', selectorStart) + 2,
);
expect(selectorBlock).toContain(
'!sessionId && unifiedPanelActive && onUnifiedDraftSelect\n ? handleUnifiedDraftSelect',
);
});

it('feeds the selector the session/draft wire id as the selected model', () => {
const selectorStart = chatInputSource.lastIndexOf('<ModelSelector');
const selectorBlock = chatInputSource.slice(
Expand Down
Loading