fix: v1.1 QA round - #289
Merged
Merged
Conversation
- Home: drop the returning-user subheading so Continue your work sits higher - Signal quality: noisy/settling thresholds raised 50% (BAD 22.5, OK 15 µV) - Clean: clicking a suggestion's trial, Accept or Restore pages the reviewer to that trial and outlines it - Clean: reviewer traces draw as one connected min/max path at device-pixel resolution (was disjoint ticks) - Analyze: head outline under the ERPs-across-the-scalp plot; legend swatches match their conditions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five fixes from the v1.1 manual QA, before tagging.
SIGNAL_QUALITY_THRESHOLDS, shared by the head diagram, the trace colors and Explore's blink calibration.EpochReviewerfocusprop; the focus clears when the arrays change after a save). Storybook check: clicking Trial 27 moved the page from 0–7 to 24–31, outlined it, and caused no page scroll.plot_evoked_topodraws no head, soplot_toponow adds a head outline (circle, nose, ears) under the traces. The legend uses explicit handles, which fixes the old swatch mismatch (the TODO is removed). Rendered with native MNE before and after.Checks:
npm run typecheckclean.tests/analysis: 20 passed.Not verified here: the thresholds against a real Muse; that needs your re-check.