feat(experiments): WS5b participant screens in built-in and custom studies - #279
Merged
Merged
Conversation
…nt; docs: WS5b learnings and TODOS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
docs/superpowers/plans/2026-09-24-ws5b-participant-screens.md: the approved #273 participant screens now run in the four built-ins and Custom. Imported jsPsych/lab.js studies are not touched (deferred, see TODOS).Commits
screens.tseach; Instruction / transition / Endcontent→ builders; the obsoleteintrocopy is deleted; stories import the real sources; key-contract test.isEEGEnabledruntime prop →parameters.isEEGEnabled, so the stillness line appears only on EEG runs (tested with real lab.js).before:preparefrom the teacher's conditions; the intro stays a${this.parameters.intro}placeholder.Stop preview), plus docs.Verification
npm run typecheck0 errors ·npm run lint0 errors (155 warnings, all pre-existing) ·npm test57 files / 297 passed, 1 skipped ·node tests/electron-smoke.mjsPASS./tmp/ws5b-screens/). Faces/Houses on EEG: instructions with the stillness line, practice showingPractice trial N of 6, the transition screen with the same keys, main trials showingTrial N of 120. Behavior-only: no stillness line anywhere; a full run reached the End screen and thenRun complete. Preview on Design and on Collect: the new screens appear with no stillness line.Found, not fixed (pre-existing): Q never skips practice in lab.js 23 (details in TODOS). Stroop, Search, Multitasking, Custom and the imported studies were not exercised in the Electron playtest. Their keys are covered by unit tests.