Skip to content

[MT-23013] Keep connection dialogs usable on short viewports #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyrylo-yevdokymov merged 3 commits into from
Jul 14, 2026
Merged

[MT-23013] Keep connection dialogs usable on short viewports #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
292d3bd
fix(connections): cap dialog height and scroll overflowing content
Jul 10, 2026
9e403b9
fixup! fix(connections): cap dialog height and scroll overflowing con…
Jul 10, 2026
232aa5e
[MT-23013] simplify dialog overflow styles
Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions frontend/src/components/connections/dialogAtoms.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import {
configBanner,
configBannerCode,
content,
contentBody,
contentHeader,
dialogLead,
dialogTitle,
field,
Expand Down Expand Up @@ -42,11 +44,15 @@ export function ConnectionDialogShell({
<Dialog.Content className={content} aria-describedby={undefined}>
{open && (
<>
<Dialog.Title asChild>
<h2 className={dialogTitle}>{title}</h2>
</Dialog.Title>
<p className={dialogLead}>{lead}</p>
{children}
<div className={contentHeader}>
<Dialog.Title asChild>
<h2 className={dialogTitle}>{title}</h2>
</Dialog.Title>
</div>
<div className={contentBody}>
<p className={dialogLead}>{lead}</p>
{children}
</div>
</>
)}
</Dialog.Content>
Expand Down Expand Up @@ -184,4 +190,3 @@ export function DialogButton({
</button>
)
}

23 changes: 15 additions & 8 deletions frontend/src/components/connections/dialogStyles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@
* AboutDialog). Keeps all dialogs visually locked to the same shell —
* palette, spacing, and control styles flow from one place.
*
* Convention: shells (`content`, `field`, `lockedHint`, `configBanner`)
* carry only the wrapper's own utilities. Per-element classes
* Convention: shells (`content`, `contentHeader`, `contentBody`,
* `field`, `lockedHint`, `configBanner`) carry only the wrapper's own
* utilities. Per-element classes
* (`dialogTitle`, `dialogLead`, `fieldLabel`, `fieldInput`, etc.) are
* applied directly to the elements they style at the dialog callsites.
* This avoids parent-side `[&_…]:` selectors that route styles through
Expand All @@ -16,16 +17,18 @@ import { inputBase } from '../../lib/styles'

export const overlay = 'fixed inset-0 z-50 bg-black/60'

// Dialog shell — positioning + chrome only. Title/lead get their own
// classes at the callsite.
// Cap dialog height while keeping the title outside the scroll area.
export const content = [
'fixed top-1/2 left-1/2 z-[51] -translate-x-1/2 -translate-y-1/2',
'w-[460px] max-w-[calc(100vw-32px)]',
'rounded-[10px] border border-border-base bg-surface-raised text-fg',
'px-6 pt-[22px] pb-5',
'flex max-h-[85vh] w-[460px] max-w-[calc(100vw-32px)] flex-col',
'overflow-hidden rounded-[10px] border border-border-base bg-surface-raised text-fg',
'shadow-[0_20px_60px_rgba(0,0,0,0.5)]',
].join(' ')

export const contentHeader = 'shrink-0 px-6 pt-[22px]'

export const contentBody = 'min-h-0 overflow-y-auto px-6'

export const dialogTitle = 'm-0 mb-1.5 text-[17px] font-semibold'

export const dialogLead = 'm-0 mb-4 text-[13px] leading-[1.5] text-fg-muted'
Expand Down Expand Up @@ -80,7 +83,11 @@ export const errorBox = [
'bg-danger-soft border-danger-border text-danger',
].join(' ')

export const actions = 'mt-[18px] flex justify-end gap-2'
// Keep actions reachable while the dialog body scrolls.
export const actions = [
'sticky bottom-0 mt-2.5 flex justify-end gap-2',
'bg-surface-raised pt-2 pb-5',
].join(' ')

// Variant-driven button. Use as `className={btn}` and set
// `data-variant="primary" | "outline" | "danger-text"` on the element
Expand Down
Loading