[MT-23018] Add accessible Tech Info tooltips#36
Conversation
|
Warning Review limit reached
Next review available in: 13 seconds Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds an accessible, portal-rendered ChangesTechnical information tooltips
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant TechInfo
participant InfoTooltip
participant RadixPortal
User->>TechInfo: Focus or hover SMTP or Email Headers help icon
TechInfo->>InfoTooltip: Render configured label and content
InfoTooltip->>RadixPortal: Render tooltip content
RadixPortal-->>User: Display technical information
User->>InfoTooltip: Press Escape or move pointer outside
InfoTooltip->>RadixPortal: Close tooltip
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
roman-adamchik
left a comment
There was a problem hiding this comment.
lgtm, but also better to use radix-ui or base-ui for headless tooltip component
|
@roman-adamchik Addressed in |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/src/components/message/InfoTooltip.tsx`:
- Around line 4-7: Update the triggerCss focus styles so keyboard focus has a
clearly visible indicator, such as a focus-visible ring or outline, instead of
relying only on the text-color change. Preserve the existing hover styling and
remove or retain focus:outline-none only as appropriate for the new
focus-visible indicator.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a9bb4964-58cb-4698-b9f2-9792b9d97743
⛔ Files ignored due to path filters (1)
frontend/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (5)
frontend/package.jsonfrontend/src/components/message/InfoTooltip.test.tsxfrontend/src/components/message/InfoTooltip.tsxfrontend/src/components/message/TechInfo.test.tsxfrontend/src/components/message/TechInfo.tsx
What & why
Implements MT-23018, a sub-task of MT-22849.
Adds explanatory SMTP Transaction Info and Email Headers tooltips. The component keeps tooltip controls outside semantic headings, exposes descriptions through
aria-describedby, remains open while hovered, and consumes Escape without triggering message-level navigation.Impact
Technical email metadata is easier to understand and the help content is usable by pointer and keyboard users.
Screenshots
Verification
npm test— 62 tests passednpm run lint— 0 errors; 4 existing warningsnpm run build— passedgit diff --check main...fix/mt-23018-tech-info-tooltips— passedSummary by CodeRabbit
New Features
Bug Fixes