[MT-23016] Resolve inline CID images safely in HTML previews#35
Closed
kyrylo-yevdokymov wants to merge 2 commits into
Closed
[MT-23016] Resolve inline CID images safely in HTML previews#35kyrylo-yevdokymov wants to merge 2 commits into
kyrylo-yevdokymov wants to merge 2 commits into
Conversation
Emails embed inline images as MIME parts referenced via cid: URLs (RFC 2392), which browsers cannot resolve, so the HTML tab's preview iframe rendered them as broken icons. The backend already serves part bytes by part_id with the original Content-Type, and the message JSON carries content_id for inline parts + attachments — nothing rewrote the references. Rewrite cid:<content-id> refs to origin-absolute part URLs before handing the HTML to MessagePreview (absolute so they also resolve in the blob:-based "open in new tab" popout). The HTML Source tab keeps the original markup. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Replaced by #41 using the repository-standard fix/mt-23016-inline-cid-images branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Fixes MT-23016, a sub-task of MT-22849.
Browsers cannot resolve MIME
cid:references directly. The preview now maps known content IDs in HTML URL attributes and CSSurl()values to the existing attachment-part endpoint. Matching is intentionally limited to URL contexts so visible message text is never rewritten.Impact
Inline images render in the HTML preview and popout while HTML Source remains unchanged.
Verification
npm test— 67 tests passednpm run lint— 0 errors; 4 existing warningsnpm run build— passedgit diff --check main...codex/mt-23016-inline-cid-images— passed