[MT-23017] Match attachment disclosure behavior to Mailtrap#33
Closed
kyrylo-yevdokymov wants to merge 3 commits into
Closed
[MT-23017] Match attachment disclosure behavior to Mailtrap#33kyrylo-yevdokymov wants to merge 3 commits into
kyrylo-yevdokymov wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Replace the inline file-chip grid with the falcon sandbox pattern: an "Attachments (N)" link under the date/size in the message header that toggles a right-aligned dropdown. Each row is a full-width download link — filename plus human size in a two-column CSS table, 45px rows — closing on outside click or toggle. Panel and text styling follow SettingsMenu (13px, fg/fg-muted, raised surface) so overlays read the same across the app. The file-type icons from the chip iteration are now unused and removed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Replaced by #37 using the repository-standard fix/mt-23017-attachments branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Implements MT-23017, a sub-task of MT-22849.
Attachments now use the Mailtrap-style disclosure list with readable filenames/sizes and full-row download links. The interaction lifecycle closes on outside click, focus leaving, or Escape; Escape restores trigger focus and is consumed before the message view's global navigation handler.
Impact
Attachment downloads are clearer and the disclosure works predictably with mouse and keyboard navigation.
Verification
npm test— 62 tests passednpm run lint— 0 errors; 4 existing warningsnpm run build— passedgit diff --check main...codex/mt-23017-attachments— passed