[MT-23015] Paginate the sidebar and preserve live consistency#32
Closed
kyrylo-yevdokymov wants to merge 2 commits into
Closed
[MT-23015] Paginate the sidebar and preserve live consistency#32kyrylo-yevdokymov wants to merge 2 commits into
kyrylo-yevdokymov wants to merge 2 commits into
Conversation
The sidebar fetched only the newest 100 messages with no way to reach the rest. Scrolling near the bottom now pages in the next batch (both for the inbox and for search results), with a loading row, an AbortController guard against racing/stale appends, and dedupe by id so live-prepended messages can't duplicate rows when offsets shift. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Replaced by #38 using the repository-standard fix/mt-23015-sidebar-pagination branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Fixes MT-23015, a sub-task of MT-22849.
The sidebar previously fetched only the newest 100 messages. This adds offset-based infinite scroll for inbox and search, server-total tracking, overlap deduplication, and stale-request invalidation when live mailbox mutations shift offsets.
Impact
Messages beyond the first page are discoverable, and concurrent create/delete events do not skip, duplicate, or resurrect rows.
Verification
npm test— 69 tests passed, including 19 Sidebar regressionsnpm run lint— 0 errors; 4 existing warningsnpm run build— passedgit diff --check main...codex/mt-23015-sidebar-pagination— passed