[MT-23013] Keep connection dialogs usable on short viewports#31
Closed
kyrylo-yevdokymov wants to merge 3 commits into
Closed
[MT-23013] Keep connection dialogs usable on short viewports#31kyrylo-yevdokymov wants to merge 3 commits into
kyrylo-yevdokymov wants to merge 3 commits into
Conversation
The connection dialogs (Cloud/Relay/Webhook/About) had no max-height: when the content grew past the viewport (e.g. SMTP Relay with the config-pin banner and Advanced section expanded on a short screen) the fixed-centered panel clipped at both edges and the action buttons became unreachable. Cap the shared shell at 85vh and make it a flex column: the title row stays pinned, the lead + form body scrolls (overflow-y: auto), and the shared DialogActions row is sticky at the bottom of the scroll area with an opaque background, so Save/Cancel/Remove stay visible at any viewport height. Spacing is preserved via a margin/padding swap on the actions row and applies to all four dialogs through dialogStyles. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Replaced by #39 using the repository-standard fix/mt-23013-dialog-overflow branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Fixes MT-23013, a sub-task of MT-22849, by capping connection-dialog height, scrolling the body, and keeping the action row reachable.
Long relay-dialog content previously exceeded short viewports because the shared shell had no bounded flex/overflow structure.
Impact
Titles remain stable while long form content scrolls and Save/Cancel actions stay available.
Verification
npm test— 58 tests passednpm run lint— 0 errors; 4 existing warningsnpm run build— passedgit diff --check main...codex/mt-23013-dialog-overflow— passed