[MT-23012] Polish UI alignment and global styling#29
Closed
kyrylo-yevdokymov wants to merge 4 commits into
Closed
Conversation
The sandbox URL hint link in CloudConnectDialog rendered the external-link icon as inline baseline content after a plain space, so on narrow dialogs the icon wrapped onto its own line and sat low relative to the text. Make the anchor an inline-flex row with the URL truncating and the icon shrink-proof, so icon and text always share one vertically centered row. Jira MT-22849, finding 2a. Findings 2b/2c (Text/Raw and HTML pop-out buttons) were already right-aligned via absolute top-0 right-0. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The app root sets font-size: 14px (index.css), so rem-based spacing utilities resolve to 87.5% of their nominal size: the track's w-8 rendered 28px instead of 32px and the thumb's h-3.5/w-3.5 rendered 12.25px instead of 14px. Mixed with the component's absolute px offsets (h-[18px], after:top-[1px], after:left-[14px]) this left the thumb riding high in the track (2px top gap vs 3.75px bottom) and nearly touching the right edge when checked, and shifted the label text 4px off the 42px toggleDesc indent that assumes a 32px track. Pin the three rem-based sizes to their documented px values (w-[32px], after:h-[14px], after:w-[14px]); the thumb is now dead-centered in both states and the label/description columns line up at every usage site. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Replaced by #40 using the repository-standard fix/mt-23012-ui-polish branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Polishes the small UI inconsistencies grouped under MT-23012, a sub-task of MT-22849:
The affected controls used a mix of wrapping flex rows, absolute positioning, and rem/px sizing, while browser-default scrollbar and selection colors did not match the app theme.
Impact
The controls retain their existing behavior but align consistently across message and connection views.
Verification
npm test— 58 tests passednpm run lint— 0 errors; 4 existing warningsnpm run build— passedgit diff --check main...codex/mt-23012-ui-polish— passed