This repository was archived by the owner on Nov 28, 2018. It is now read-only.
increasing compatibility with foreach+curl_setopt#2
Open
jessevondoom wants to merge 1 commit into
Open
Conversation
Just deployed a well-tested app to a vanilla PHP instance on AppFog, which is a Cloud Foundry provider. MailChimp integration went from rock solid to fully broken. After wrestling with it I found the culprit to be curl_setopt_array on line 504 here. For some reason it just wasn't setting the URL properly, causing a "No URL set!" curl error. I know it's not your code, but this fixed everything immediately. I re-ran our tests and verified that it didn't break the local copy that was previously working, and it didn't cause any noticeable slow-down. Figured a quickie patch might let you guys focus on MailChimp examples instead of trying to debug this one for the next person who spins up an AppFog/Cloud Foundry instance to try things out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just deployed a well-tested app to a vanilla PHP instance on AppFog, which is a Cloud Foundry provider. MailChimp integration went from rock solid to fully broken. After wrestling with it I found the culprit to be curl_setopt_array on line 504 here. For some reason it just wasn't setting the URL properly, causing a "No URL set!" curl error.
I know it's not your code, but this fixed everything immediately. I re-ran our tests and verified that it didn't break the local copy that was previously working, and it didn't cause any noticeable slow-down.
Figured a quickie patch might let you guys focus on MailChimp examples instead of trying to debug this one for the next person who spins up an AppFog/Cloud Foundry instance to try things out.