Conversation
chore: pin node and npm versions
feat: change default favico
natanchik
left a comment
There was a problem hiding this comment.
Consider splitting the code and extracting components and utility functions into their own files.
| <Card> | ||
| <CardHeader> | ||
| <CardTitle>Aleksei</CardTitle> | ||
| <CardDescription>{t("teamLead")}</CardDescription> | ||
| </CardHeader> | ||
| <CardContent> | ||
| <Link | ||
| href="https://github.com/maiano" | ||
| target="_blank" | ||
| className="text-primary text-sm hover:underline" | ||
| > | ||
| github.com/maiano | ||
| </Link> | ||
| </CardContent> | ||
| </Card> | ||
|
|
||
| <Card> | ||
| <CardHeader> | ||
| <CardTitle>Katya</CardTitle> | ||
| <CardDescription>{t("developer")}</CardDescription> | ||
| </CardHeader> | ||
| <CardContent> | ||
| <Link | ||
| href="https://github.com/KatherinaSl" | ||
| target="_blank" | ||
| className="text-primary text-sm hover:underline" | ||
| > | ||
| github.com/KatherinaSl | ||
| </Link> | ||
| </CardContent> | ||
| </Card> | ||
|
|
||
| <Card> | ||
| <CardHeader> | ||
| <CardTitle>Dilafruz</CardTitle> | ||
| <CardDescription>{t("developer")}</CardDescription> | ||
| </CardHeader> | ||
| <CardContent> | ||
| <Link | ||
| href="https://github.com/Dilafruz-17" | ||
| target="_blank" | ||
| className="text-primary text-sm hover:underline" | ||
| > | ||
| github.com/Dilafruz-17 | ||
| </Link> | ||
| </CardContent> | ||
| </Card> |
There was a problem hiding this comment.
You could map the cards to reduce duplication.
There was a problem hiding this comment.
Thank you, I'll replace the duplicated cards with a mapped array
| import { Badge } from "@/shared/ui/badge"; | ||
| import { Button } from "@/shared/ui/button"; |
There was a problem hiding this comment.
Consider adding an index.ts with re-exports for cleaner imports.
There was a problem hiding this comment.
Thanks, I'll guess about it. I prefer direct imports because they were more explicit and make it easier to see where the component is in a given case
| <Button asChild variant="outline" size="sm"> | ||
| <Link href={href} aria-label={label}> | ||
| {children} | ||
| </Link> | ||
| </Button> |
There was a problem hiding this comment.
Choose one option: either a Button or a Link. If this is used for navigation, use a Link even if it looks like a button.
There was a problem hiding this comment.
I guess i used shadcn asChild pattern. The rendered element is still the Link/<a>; Button only provides styling through Slot.
Feature 1: App Header(60 points)
Feature 2: Sign In / Sign Up (50 points)
Feature 3: Swagger Editor (120 points)
Feature 4: Swagger Viewer (120 points)
Feature 5: History and Analytics (70 points)
Feature 6: About Page (25 points)
Feature 7: General Requirements (55 points)
Feature 8: YouTube Video (50 points)