Don't return cached errors, allow to retry

packages/core/src/idempotency.ts

@@ -167,6 +167,12 @@ export class Idempotency {
     if (await this.isEnabled(reqInternal)) {
       const fingerPrint = this.getFingerPrint(reqInternal);
       const cacheKey = this.getIdempotencyCacheKey(reqInternal);
+
+      if (res.error && req.options?.skipErrorsCache) {
+        // do not cache the error itself, clear the cache key and allow subsequent requests to retry
+        await this.storage.delete(cacheKey);
+      }
+
       const payload: StoragePayload = {
         status: RequestStatusEnum.COMPLETE,
         fingerPrint,

packages/core/src/types.ts

@@ -30,6 +30,12 @@ export interface IdempotencyOptions {
    * if set to `true` requests without idempotency key header will be rejected
    */
   enforceIdempotency?: boolean;
+  /**
+   * @defaultValue `false`
+   *
+   * if set to `true` responses with errors will not be cached
+   */
+  skipErrorsCache?: boolean;
 
   /**
    * @defaultValue `undefined`

packages/storage-adapter-memory/src/adapter-memory.ts

@@ -47,4 +47,8 @@ export class MemoryStorageAdapter implements StorageAdapter {
     }
     return val?.item;
   }
+
+  async delete(key: string): Promise<void> {
+    this.cache.delete(key);
+  }
 }

packages/storage-adapter-redis/src/adapter-redis.ts

@@ -50,4 +50,8 @@ export class RedisStorageAdapter implements StorageAdapter {
     const val = await this.client.get(key);
     return val ?? undefined;
   }
+
+  async delete(key: string): Promise<void> {
+    await this.client.del(key);
+  }
 }

packages/storage/src/types.ts

@@ -6,6 +6,7 @@ export interface StorageAdapter {
   ) => Promise<boolean>;
   set: (key: string, val: string, { ttl }: { ttl?: number }) => Promise<void>;
   get: (key: string) => Promise<string | undefined>;
+  delete: (key: string) => Promise<void>;
   connect?: () => Promise<void>;
   disconnect?: () => Promise<void>;
 }