Conversation
Move both jobs to the shared lua-ci container so the Lua and LuaRocks setup is consistent across linting, the version matrix, and coverage upload, and pass the dev rockspec path to luarocks make so the right build is selected even when the directory holds many versioned rockspecs.
The codec and parser call luaL_* APIs directly, so they should include Lua's auxiliary library header rather than relying on transitive project headers.
Drop the bespoke Makefile and let the rockspec drive the build the same way as other lua-* modules, with coverage flags toggled through conditional_variables under URL_COVERAGE.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19 +/- ##
==========================================
+ Coverage 87.89% 88.06% +0.17%
==========================================
Files 2 2
Lines 512 511 -1
==========================================
Hits 450 450
+ Misses 62 61 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the build and CI pipeline to modernize and simplify the Lua module's workflow, moving from a custom
Makefileand legacy GitHub Actions setup to a container-based, hooks-driven approach with improved dependency management. It also cleans up C source includes for consistency.CI/CD Pipeline Modernization:
.github/workflows/test.yml) now uses a containerized environment (ghcr.io/mah0x211/lua-ci:latest) for both linting and testing, removing the need for manual Lua and Luarocks setup steps. Lua version switching is handled withlenv. [1] [2]v5) and OIDC authentication for improved security and reliability.Build System and Dependency Management:
Makefileis removed in favor of a newrockspecs/url-scm-1.rockspecthat usesluarocks-build-hookswith a hooks-based build, simplifying build logic and centralizing configuration. [1] [2] [3]rockspecnow specifies build and conditional dependencies, and modularizes the build ofurl,url.codec, andurl.parse.C Source Code Cleanup:
src/codec.candsrc/parse.cstandardize and clarify the inclusion of dependencies and system headers, improving maintainability. [1] [2]