Conversation
The current waitpid release made sec a positional argument and stopped turning ECHILD into an error, so act.waitpid passed 'nohang' into the sec slot and asserted on a now-suppressed ECHILD error. Pass nil for sec, drop the ECHILD assertion, and refresh the dependency floors so luarocks resolves to the releases that match these expectations.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #56 +/- ##
==========================================
- Coverage 94.33% 93.42% -0.92%
==========================================
Files 13 18 +5
Lines 1042 1278 +236
==========================================
+ Hits 983 1194 +211
- Misses 59 84 +25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Cover the act.bitset and act.stack public APIs so future changes to the resizable bitset implementation in bitset.h and the lua_State- backed stack are guarded by regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the CI workflow and the build configuration for the project, focusing on improving test reliability, coverage reporting, and build flexibility. It also includes minor dependency and code organization updates for better maintainability and compatibility.
CI/CD and Coverage Improvements:
.github/workflows/test.ymlto use a containerized environment (ghcr.io/mah0x211/lua-ci:latest) for both linting and testing jobs, removed setup steps for Lua/Luarocks in favor of container-provided tools, and restricted workflow triggers to non-markdown, non-license file changes. The test matrix now uses new version tags, and coverage upload is improved with OIDC and multiple file support. [1] [2]covgen.shscript to generatelcovcoverage reports, filtering out include files, and integrated it into the workflow.Build System and Dependency Updates:
rockspecs/act-scm-1.rockspecto userockspec_format = "3.0", increasedlauxhlibminimum version, addedluarocks-build-hooksas a build dependency, and switched the build type tohookswith support for coverage flags and extra variables. [1] [2] [3]Code Organization and Minor Fixes:
src/bitset.c,src/getcpus.c,src/ignsigpipe.c, andsrc/stack.cfor clarity and consistency, separating project, dependency, Lua, and system headers. [1] [2] [3] [4]src/stack.cfor code cleanliness.