Repository navigation
[pull] main from vavallee:main - #18
Merged
Merged
Conversation
…release is rejected (#2863) (#2872) conflictingTitleAuthor only read an attribution directly after the title ("<title> by <author>") or after a spaced dash. A series label in between, as in "Heart of Glass, Skye Druids (03) by Donna Grant EPUB", hid it, so the release was accepted on its title alone and grabbed for Jennifer Hillier's "Heart of Glass". When the release starts with the requested title and neither existing form applies, look for the first "by" in the part after the title, within a short series label, and read the words after it (up to a format, release marker or year) as the attribution for the existing author comparison. A "by" after a narrator, translator or uploader word is ignored, and a release with no parsable attribution is accepted as before. filterRelevantDebug, which both production search paths run (SearchBookWithOutcomes for automatic search, SearchBookWithDebug for the interactive panel), never called conflictingTitleAuthor, so the fix would not have reached a real search. It now runs the same guard and records the drop reason. Draft #2812 folds both filters into one implementation; this is the minimal slice of that needed for #2863. Claude-Session: https://claude.ai/code/session_016fJcCVbNnKsmj2MAAMwWj9 Signed-off-by: vavallee <vavallee@protonmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…fix gosec G115 (#2868) (#2873) On macOS t.TempDir() sits under /var, a symlink to /private/var. Scan reports units under the symlink-resolved folder, so seven TestManualImportScan tests built expectations from a path form the scan never returns. They now take their root from resolvedTempDir. The same mismatch is a real production gap on any platform: book_files stores paths under the library root as configured, while Scan walks the resolved folder, so a symlinked library root never matched by exact path and only the inode fallback hid tracked files. That fallback cannot see a tracked file that was missing when the index was built or was rewritten in place since, and both surfaced as importable. trackedFileIndex now also indexes each tracked path with its directory components resolved, memoised per directory so a cold rebuild costs one extra lstat per distinct library directory rather than one EvalSymlinks per row. samedevice_unix.go: Stat_t.Dev is int32 on darwin and openbsd, which gosec G115 flags. The value is only compared for equality and the conversion is injective, so it carries a targeted nolint with the reason. Claude-Session: https://claude.ai/code/session_016fJcCVbNnKsmj2MAAMwWj9 Signed-off-by: vavallee <vavallee@protonmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016fJcCVbNnKsmj2MAAMwWj9 Signed-off-by: vavallee <vavallee@protonmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )