Repository navigation
Conversation
yetone
left a comment
There was a problem hiding this comment.
Thanks. The Chinese recall fix works. With the old scoring swapped back in, your CJK test goes red. Two things are needed before this can merge:
- Bump
packages/chatto 0.1.12. 0.1.11 is already published to the dist branch, so as it stands no user would ever get this change. - Add tests for the other two rules, so each fails without its rule. I removed each rule by hand and all 5 tests still passed:
- Without the
+1000boost for an exact rawName match, nothing goes red. A test needs a query that names a tool exactly and would rank it lower without the boost, for example a common word shared with many other tools. - With the IDF weight replaced by
1, nothing goes red. A test needs a query where a rare term must beat a term most tools contain.
- Without the
Minor: the commit subject carries an internal ticket id ("QMCP-2014"). It means nothing in this repo, so please drop it when you squash.
What I ran, on a separate macOS box with a sandbox HOME:
packages/chat:bun testgave 73 pass and 1 skip.bun scripts/check.mjs chat: ✓
I read every line of the diff and found no licensing, telemetry or vendor-text concerns.
|
Thanks, this looks right. I read every line and ran it at 6b7a528 merged onto main f379bf9 on a separate machine (bun 1.4.2, temp HOME): One change before merge: bump Two small points, not blockers:
|
Problem
Chat splits tool-search queries on non-alphanumeric/non-CJK characters. An unspaced Chinese request becomes a single long term and fails to match relevant tool descriptions. In desktop QCC OAuth acceptance, a natural-language historical-patent request missed the available tool; explicitly naming the tool succeeded.
Change
Extract Chinese bigrams alongside existing Latin identifiers, weight terms by catalog frequency to reduce repeated boilerplate, and prioritize explicitly named raw tool identifiers. Keep the 12-schema cap and bounded common-tool fallback. No QCC-specific routing, credentials, or queries are included.
This remains lexical selection, not semantic discovery or a guarantee that every tool is recalled. OAuth relay reuse is a separate issue.
Validation