Skip to content

Improve Fingerprint icon and provider menu - #861

Open
KaranocaVe wants to merge 4 commits into
magpie-community:mainfrom
KaranocaVe:feat/fingerprint-icon
Open

KaranocaVe wants to merge 4 commits into
magpie-community:mainfrom
KaranocaVe:feat/fingerprint-icon

Conversation

@KaranocaVe

@KaranocaVe KaranocaVe commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Add the fingerprint icon to the plugin list and sidebar, and fix the provider menu being clipped by the models panel. The menu now stays within the viewport and supports scrolling and keyboard navigation for long lists. Bump the package to 0.2.4 and derive the service version from package.json to keep the reported version in sync. Verified with 35 providers in a 420 x 450 viewport; the isolated rebuild, 37 tests, typecheck, and community Fingerprint check pass. Includes the fix from #862. Fixes #860.

@yetone

yetone commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Thanks. The icon fields are the ones magpie reads: magpie.icon for the plugin list and magpie.page.icon (inside page/) for the page's sidebar entry. A fixed stroke colour is fine here; other page icons use one too.

One thing blocks the merge. packages/fingerprint stays at 0.2.3, so nothing gets published and nobody sees the icon. Could you bump version to 0.2.4 in package.json, and also update the VERSION constant if it's still out of step (#860)? I'll merge after that.

Reviewed at e2557b3; CI is green.

@KaranocaVe KaranocaVe changed the title Add fingerprint icon to Fingerprint page Improve Fingerprint icon and provider menu Nov 8, 2026
@KaranocaVe

Copy link
Copy Markdown
Contributor Author

The requested release sync is in place: the package is 0.2.4, and the reported service version is derived from package metadata. The latest branch head a45aedb also includes the Windows port diagnostics and WebView2 launcher fallback/copy handling for KaranocaVe/magpie-fingerprint issues #1 and #2. Local isolated rebuild passes typecheck, all 38 tests, and build; GitHub test and on-npm checks both pass. The fallback copies the local URL; launching the system browser needs an upstream native bridge because the current plugin sandbox does not permit popups or top-level navigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fingerprint: service-identity VERSION says 0.2.2 while the package is 0.2.3

2 participants