Open
Conversation
Collaborator
Fuco1
commented
Oct 14, 2016
Fuco1
commented
- Remove emacs 23 tests
- Run tests using the evm & cask combo (as is standard these days)
- Run tests for all 24.* versions as well as 25.1
- Add coveralls support
Owner
|
Looking good! |
Collaborator
Author
|
Can't get undercover to work, it alawys gives me I don't see anything that should compile dash before tests. Hmm. |
Fuco1
force-pushed
the
feature/coverall-integration
branch
2 times, most recently
from
1501d9c to
728d44d
Compare
Collaborator
Author
|
So the problem was with doing |
Contributor
|
Might I suggest separating out the EVM changes from moving to coveralls? AFAICS the EVM + cask work is ready to merge. |
Collaborator
Author
|
That's a good idea. I'm finishing next smartparens release now so I'll probably spend the weekend on that. Do you want to try and get this separated? |
Fuco1
referenced
this pull request
Nov 9, 2016
Fuco1
force-pushed
the
feature/coverall-integration
branch
from
b903a0f to
2e8d667
Compare
Collaborator
|
Is this still something we want to have? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.