Add '-sort-keyed'.#166
Open
doublep wants to merge 1 commit intomagnars:masterfrom
doublep:sort-keyed
Open
Conversation
| COMPARATOR is called with two keys, and should return non-nil if | ||
| the first one (and thus its associated LIST element) should sort | ||
| before the second." | ||
| (if (cdr list) |
Collaborator
There was a problem hiding this comment.
Is this really necessary? Map and sort on empty list returns nil, so that's not a problem, and while calling it on a list with length one is pointless, the performance hit is so negigible it is not worth the extra complexity.
Collaborator
|
I think we should rename this to |
Collaborator
|
Dash now uses lexical binding so it should be safe. How are you on time? Do you want to finish this? :) |
basil-conto
added
the
enhancement
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #156