Skip to content

Fix nightly ICE: prevent tokio rt-multi-thread from being activated via --features srv - #14

Closed
magiclen with Copilot wants to merge 1 commit into
masterfrom
copilot/fix-failing-github-actions-job
Closed

Fix nightly ICE: prevent tokio rt-multi-thread from being activated via --features srv#14
magiclen with Copilot wants to merge 1 commit into
masterfrom
copilot/fix-failing-github-actions-job

Conversation

Copilot AI commented Jul 25, 2026

Copy link
Copy Markdown

cargo test --features srv fails on nightly rustc (1.99.0-nightly, 2026-07-24) with an internal compiler error in rustc_codegen_ssa when compiling tokio-1.53.1 with the rt-multi-thread feature.

Root cause

rt-multi-thread is pulled in transitively:

whois-rust (--features srv)
  → hickory-client 0.24.4 (default features)
    → hickory-proto 0.24.4 (feature: tokio-runtime)
      → tokio/rt-multi-thread

hickory-client and hickory-proto both use default-features = true on their tokio dependency, and hickory-proto's tokio-runtime feature explicitly enables tokio/rt-multi-thread.

Changes

  • Set default-features = false on the hickory-client dependency in Cargo.toml to prevent hickory-proto's tokio-runtime feature from activating tokio/rt-multi-thread unnecessarily when only the synchronous SRV DNS lookup path is used.

Copilot AI changed the title [WIP] Fix failing GitHub Actions job 'Test nightly on ubuntu-latest' Fix nightly ICE: prevent tokio rt-multi-thread from being activated via --features srv Jul 25, 2026
Copilot AI requested a review from magiclen July 25, 2026 13:50
@magiclen magiclen closed this Jul 27, 2026
@magiclen
magiclen deleted the copilot/fix-failing-github-actions-job branch July 27, 2026 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants