Skip to content

Enhance cacheability check in isRequestCacheable method #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mage-os-ci merged 1 commit into from
Apr 19, 2026
+8 −0
Merged

Enhance cacheability check in isRequestCacheable method #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Plugin/Framework/App/Response/Http.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,14 @@ public function afterSetNoCacheHeaders(\Magento\Framework\App\Response\Http $sub
*/
private function isRequestCacheable(string $cacheControl): bool
{
// FPC hits will not have public or private cache control directives -- already processed
if (!str_contains($cacheControl, 'public')
&& !str_contains($cacheControl, 'private')
&& !str_contains($cacheControl, 'no-store')) {
return true;
}

// FPC misses will be cacheable if they have a public directive
return (bool) preg_match('/public.*s-maxage=(\d+)/', $cacheControl);
}

Expand Down
Loading