Skip to content

Rename console commands to match what they do #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rikwillems wants to merge 1 commit into from
Closed

Rename console commands to match what they do #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Console/Command/SelectAttributeTest.php → ...ranslateProductSelectAttributeOptions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

class SelectAttributeTest extends Command
class TranslateProductSelectAttributeOptions extends Command
{
/**
* @param TranslateSelectAttributes $translateSelectAttributes
Expand All @@ -27,8 +27,8 @@ public function __construct(
*/
protected function configure(): void
{
$this->setName('mage-os:select-attribute:test');
$this->setDescription('Test select attribute translation');
$this->setName('mage-os:translate:product-select-attribute-options');
$this->setDescription('Translate product select attribute options');
parent::configure();
}

Expand Down
6 changes: 3 additions & 3 deletions Console/Command/TestProcedure.php → Console/Command/TranslateProducts.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

class TestProcedure extends Command
class TranslateProducts extends Command
{
/**
* @param TranslateProductsInterface $translateProducts
Expand All @@ -27,8 +27,8 @@ public function __construct(
*/
protected function configure(): void
{
$this->setName('mage-os:procedure:test');
$this->setDescription('Test the translation procedure by shell');
$this->setName('mage-os:translate:products');
$this->setDescription('Translate products');
parent::configure();
}

Expand Down
4 changes: 2 additions & 2 deletions etc/di.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
<arguments>
<argument name="commands" xsi:type="array">
<item name="mageos_automatictranslation_test" xsi:type="object">MageOS\AutomaticTranslation\Console\Command\TestTranslation</item>
<item name="mageos_automatictranslation_test_procedure" xsi:type="object">MageOS\AutomaticTranslation\Console\Command\TestProcedure</item>
<item name="mageos_automatictranslation_select_attribute_test" xsi:type="object">MageOS\AutomaticTranslation\Console\Command\SelectAttributeTest</item>
<item name="mageos_automatictranslation_translate_products" xsi:type="object">MageOS\AutomaticTranslation\Console\Command\TranslateProducts</item>
<item name="mageos_automatictranslation_translate_product_select_attribute_options" xsi:type="object">MageOS\AutomaticTranslation\Console\Command\TranslateProductSelectAttributeOptions</item>
</argument>
</arguments>
</type>
Expand Down