Skip to content

PHP 8.3 update + full module refactor#52

Merged
SamueleMartini merged 2 commits intomainfrom
release/php83-update
Mar 12, 2026
Merged

PHP 8.3 update + full module refactor#52
SamueleMartini merged 2 commits intomainfrom
release/php83-update

Conversation

@SamueleMartini
Copy link
Copy Markdown
Collaborator

@SamueleMartini SamueleMartini commented Mar 12, 2026

Summary

  • Added declare(strict_types=1) to all PHP files
  • Guard clauses and lazy computation throughout the module
  • Deduplicated store filtering logic via getEnabledStores(callable)
  • Fixed critical bug: translateParsedContent() param typed string but receives array|string
  • Removed dead dependencies, unused imports, redundant annotations
  • Specific exception catching (NoSuchEntityException instead of generic Exception)
  • Functional style: array_map/array_filter, arrow functions, spaceship operator
  • Fixed typos and added previous exception chaining

Test plan

  • Verify product translation works (text + Page Builder attributes)
  • Verify category translation works
  • Verify CMS page/block translation works
  • Verify select attribute translation via cron
  • Verify admin translate buttons appear and function correctly
  • Verify all translation engines (DeepL, OpenAI, Gemini) still work

@SamueleMartini SamueleMartini requested review from a team and dadolun95 as code owners March 12, 2026 18:03
@SamueleMartini SamueleMartini merged commit f0636e0 into main Mar 12, 2026
2 checks passed
@SamueleMartini SamueleMartini deleted the release/php83-update branch March 12, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants