Skip to content

fix runtime error in supported-versions dist; update action runner to…#308

Merged
mage-os-ci merged 1 commit intomage-os:mainfrom
rhoerr:fix/supported-versions-dist
Dec 13, 2025
Merged

fix runtime error in supported-versions dist; update action runner to…#308
mage-os-ci merged 1 commit intomage-os:mainfrom
rhoerr:fix/supported-versions-dist

Conversation

@rhoerr
Copy link
Copy Markdown
Contributor

@rhoerr rhoerr commented Dec 13, 2025

… node v20; fix schema warning

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Supported-versions action threw an error on execution with its currently merged version. I reproduced locally. This PR primarily just recompiles the script. In the process, I updated the action from node16 to node20 (which matches my local versions, and I think the actual action already uses anyway), and removed a deprecated value property.

Fixes: #307

What is the new behavior?

Should work now.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Tests pass successfully. Outputs successfully.
mageos@mainframe:/var/www/mage-os/mage-os.github-actions/supported-version$ npm run build

> @mage-os/github-actions-supported-version@1.0.0 build
> npx esbuild --outfile=dist/index.js --platform=node --bundle --minify src/index.ts


  dist/index.js  487.4kb

⚡ Done in 12ms
mageos@mainframe:/var/www/mage-os/mage-os.github-actions/supported-version$ npm run test

> @mage-os/github-actions-supported-version@1.0.0 test
> jest

 PASS  src/versions/get-versions-for-project.spec.ts
  getIndividialVersionsForProject
    ✓ returns individual versions matrix for magento-open-source (1 ms)
    ✓ throws error if no individual versions are specified for given project (2 ms)
  getCompositeVersionsForProject
    ✓ returns composite versions matrix for magento-open-source
    ✓ throws error if no composite versions are specified for given project

 PASS  src/kind/validate-kinds.spec.ts
  validateKind
    ✓ returns `true` if its a valid kind
    ✓ throws a helpful exception if its an invalid kind (1 ms)
    ✓ throws a helpful exception if custom versions are provided with the wrong kind
    ✓ returns `true` for kind `custom` with a custom versions

 PASS  src/project/validate-projects.spec.ts
  validateProject
    ✓ returns `true` if its a valid project (1 ms)
    ✓ throws a helpful exception if it is an invalid project (1 ms)

 PASS  src/nightly/amend-matrix-for-next.spec.ts
  amendMatrixForNext
    ✓ should amend the "next" versions listed in the matrix output for the given repo (1 ms)
    ✓ should should do nothing to matrixes that contain no next versions
    ✓ should only modify next versions
    ✓ should amend the "next" versions listed in the matrix output for the given repo, for a different project (1 ms)

 PASS  src/kind/get-usable.spec.ts
  getUsableVersions for magento-open-source
    ✓ should return an array of versions
    ✓ should filter out versions with composer < 2.0.0
    ✓ should handle composer version equal to 2.0.0

 PASS  src/nightly/unify-next-package-name.spec.ts
  unifyNextPackageName
    ✓ should do nothing to an unknown package
    ✓ should do nothing to a next-available package at a non-next version
    ✓ should do nothing to a next package at a next version on a repo that doesnt support that version
    ✓ should convert the next version to the specific format of the repo that supports the next version
    ✓ should convert the next version to the specific format of the repo that supports the next version

 PASS  src/kind/get-currently-supported.spec.ts
  getCurrentlySupportedVersions for magento-open-source
    ✓ should say that v2.4.0 is not supported in 2025 (1 ms)
    ✓ supportedVersions for 2023-01-01T00:00:00Z
    ✓ supportedVersions for 2023-03-14T00:00:00Z
    ✓ supportedVersions for 2023-03-15T00:00:00Z
    ✓ supportedVersions for 2023-10-09T00:00:00Z (1 ms)
    ✓ supportedVersions for 2023-10-11T00:00:00Z
    ✓ supportedVersions for 2024-01-01T00:00:00Z
    ✓ supportedVersions for 2024-12-31T00:00:00Z
    ✓ supportedVersions for 2025-06-09T00:00:00Z
    ✓ supportedVersions for 2025-06-10T00:00:01Z (1 ms)
    ✓ supportedVersions for 2025-08-11T00:00:00Z
    ✓ supportedVersions for 2025-08-12T00:00:00Z
    ✓ supportedVersions for 2025-08-14T00:00:00Z
    ✓ supportedVersions for 2025-12-31T00:00:00Z
    ✓ supportedVersions for 2026-03-15T00:00:00Z (1 ms)
    ✓ supportedVersions for 2027-04-09T00:00:00Z
    ✓ supportedVersions for 2027-04-10T00:00:00Z
  getCurrentlySupportedVersions for mage-os
    ✓ should say that v1.0.0 is not supported in 2027
    ✓ supportedVersions for 2023-01-01T00:00:00Z
    ✓ supportedVersions for 2023-10-10T15:00:00Z
    ✓ supportedVersions for 2024-01-01T00:00:00Z
    ✓ supportedVersions for 2024-07-17T00:00:00Z
    ✓ supportedVersions for 2024-07-18T00:00:01Z
    ✓ supportedVersions for 2025-04-22T00:00:01Z
    ✓ supportedVersions for 2025-08-13T00:00:01Z
    ✓ supportedVersions for 2025-09-09T00:00:01Z

 PASS  src/nightly/get-next-version.spec.ts
  getNextVersion
    ✓ should get the next nightly version for Magento Open Source
    ✓ should get the next nightly version for Mage-OS
    ✓ should handle the first of the month correctly

 PASS  src/project/validations/is-known-project.spec.ts
  isKnownProject
    ✓ returns `true` for known projects
    ✓ throws a message if for unknown projects (1 ms)

 PASS  src/matrix/get-matrix-for-kind.spec.ts
  getMatrixForKind for mage-os
    ✓ returns a matrix for `latest`
    ✓ returns a matrix for `currently-supported` (1 ms)
    ✓ returns a matrix for `all`
    ✓ returns a matrix for valid `custom`
    ✓ returns a matrix nightly`
    ✓ returns a matrix for the next release when using `nightly`
    ✓ errors for invalid `custom`` (2 ms)
  getMatrixForKind for magento-open-source
    ✓ returns a matrix nightly` (1 ms)
    ✓ returns a matrix for `latest`
    ✓ returns a matrix for `currently-supported`
    ✓ returns a matrix for `all`
    ✓ returns a matrix for valid `custom`
    ✓ returns a matrix for the next release when using `nightly` (1 ms)
    ✓ returns a matrix for valid multiple `custom`
    ✓ errors for invalid `custom``

Test Suites: 10 passed, 10 total
Tests:       68 passed, 68 total
Snapshots:   0 total
Time:        0.698 s, estimated 1 s
Ran all test suites.
mageos@mainframe:/var/www/mage-os/mage-os.github-actions/supported-version$ INPUT_KIND=all INPUT_PROJECT=mage-os node dist/index.js

::set-output name=matrix::{"magento":["mage-os/project-community-edition:1.0.0","mage-os/project-community-edition:1.0.1","mage-os/project-community-edition:1.0.2","mage-os/project-community-edition:1.0.3","mage-os/project-community-edition:1.0.4","mage-os/project-community-edition:1.0.5","mage-os/project-community-edition:1.0.6","mage-os/project-community-edition:1.1.0","mage-os/project-community-edition:1.1.1","mage-os/project-community-edition:1.2.0","mage-os/project-community-edition:1.3.0","mage-os/project-community-edition:1.3.1","mage-os/project-community-edition:2.0.0"],"include":[{"magento":"mage-os/project-community-edition:1.0.0","upstream":"2.4.6-p3","php":8.1,"composer":"2.2.21","mysql":"mysql:8.0","elasticsearch":"elasticsearch:8.5.3","rabbitmq":"rabbitmq:3.9-management","redis":"redis:7.0","varnish":"varnish:7.3","nginx":"nginx:1.22","os":"ubuntu-latest","release":"2023-10-10T00:00:00+0000","eol":"2023-10-11T00:00:00+0000"},{"magento":"mage-os/project-community-edition:1.0.1","upstream":"2.4.6-p3","php":8.1,"composer":"2.2.21","mysql":"mysql:8.0","elasticsearch":"elasticsearch:8.5.3","rabbitmq":"rabbitmq:3.9-management","redis":"redis:7.0","varnish":"varnish:7.3","nginx":"nginx:1.22","os":"ubuntu-latest","release":"2023-10-11T00:00:00+0000","eol":"2024-07-17T00:00:00+0000"},{"magento":"mage-os/project-community-edition:1.0.2","upstream":"2.4.7-p1","php":8.3,"composer":"2.7.4","mysql":"mariadb:10.6","elasticsearch":"elasticsearch:8.11.4","rabbitmq":"rabbitmq:3.13-management","redis":"redis:7.2","varnish":"varnish:7.5","nginx":"nginx:1.26","os":"ubuntu-latest","release":"2024-07-18T00:00:00+0000","eol":"2024-07-22T00:00:00+0000"},{"magento":"mage-os/project-community-edition:1.0.3","upstream":"2.4.7-p1","php":8.3,"composer":"2.7.4","mysql":"mariadb:10.6","elasticsearch":"elasticsearch:8.11.4","rabbitmq":"rabbitmq:3.13-management","redis":"redis:7.2","varnish":"varnish:7.5","nginx":"nginx:1.26","os":"ubuntu-latest","release":"2024-07-23T00:00:00+0000","eol":"2024-08-19T00:00:00+0000"},{"magento":"mage-os/project-community-edition:1.0.4","upstream":"2.4.7-p2","php":8.3,"composer":"2.7.4","mysql":"mariadb:10.6","elasticsearch":"elasticsearch:8.11.4","rabbitmq":"rabbitmq:3.13-management","redis":"redis:7.2","varnish":"varnish:7.5","nginx":"nginx:1.26","os":"ubuntu-latest","release":"2024-08-20T00:00:00+0000","eol":"2024-10-08T00:00:00+0000"},{"magento":"mage-os/project-community-edition:1.0.5","upstream":"2.4.7-p3","php":8.3,"composer":"2.7.4","mysql":"mariadb:10.6","elasticsearch":"elasticsearch:8.11.4","rabbitmq":"rabbitmq:3.13-management","redis":"redis:7.2","varnish":"varnish:7.5","nginx":"nginx:1.26","os":"ubuntu-latest","release":"2024-10-09T00:00:00+0000","eol":"2025-02-11T00:00:00+0000"},{"magento":"mage-os/project-community-edition:1.0.6","upstream":"2.4.7-p4","php":8.3,"composer":"2.7.4","mysql":"mariadb:10.6","elasticsearch":"elasticsearch:8.11.4","rabbitmq":"rabbitmq:3.13-management","redis":"redis:7.2","varnish":"varnish:7.5","nginx":"nginx:1.26","os":"ubuntu-latest","release":"2025-02-12T00:00:00+0000","eol":"2025-04-07T00:00:00+0000"},{"magento":"mage-os/project-community-edition:1.1.0","upstream":"2.4.8","php":8.4,"composer":"2.8.8","mysql":"mysql:8.4","opensearch":"opensearchproject/opensearch:2.19.1","rabbitmq":"rabbitmq:4.0-management","redis":"redis:7.2","varnish":"varnish:7.6","nginx":"nginx:1.26","os":"ubuntu-latest","release":"2025-04-15T00:00:00+0000","eol":"2025-04-21T00:00:00+0000"},{"magento":"mage-os/project-community-edition:1.1.1","upstream":"2.4.8","php":8.4,"composer":"2.8.8","mysql":"mysql:8.4","opensearch":"opensearchproject/opensearch:2.19.1","rabbitmq":"rabbitmq:4.0-management","redis":"redis:7.2","varnish":"varnish:7.6","nginx":"nginx:1.26","os":"ubuntu-latest","release":"2025-04-22T00:00:00+0000","eol":"2025-06-16T00:00:00+0000"},{"magento":"mage-os/project-community-edition:1.2.0","upstream":"2.4.8-p1","php":8.4,"composer":"2.8.8","mysql":"mysql:8.4","opensearch":"opensearchproject/opensearch:2.19.1","rabbitmq":"rabbitmq:4.0-management","redis":"redis:7.2","varnish":"varnish:7.6","nginx":"nginx:1.26","os":"ubuntu-latest","release":"2025-06-17T00:00:00+0000","eol":"2025-08-12T00:00:00+0000"},{"magento":"mage-os/project-community-edition:1.3.0","upstream":"2.4.8-p2","php":8.4,"composer":"2.8.8","mysql":"mysql:8.4","opensearch":"opensearchproject/opensearch:2.19.1","rabbitmq":"rabbitmq:4.0-management","redis":"redis:7.2","varnish":"varnish:7.6","nginx":"nginx:1.26","os":"ubuntu-latest","release":"2025-08-13T00:00:00+0000","eol":"2025-09-08T00:00:00+0000"},{"magento":"mage-os/project-community-edition:1.3.1","upstream":"2.4.8-p2","php":8.4,"composer":"2.8.8","mysql":"mysql:8.4","opensearch":"opensearchproject/opensearch:2.19.1","rabbitmq":"rabbitmq:4.0-management","redis":"redis:7.2","varnish":"varnish:7.6","nginx":"nginx:1.26","os":"ubuntu-latest","release":"2025-09-09T00:00:00+0000","eol":"2025-10-16T00:00:00+0000"},{"magento":"mage-os/project-community-edition:2.0.0","upstream":"2.4.8-p3","php":8.4,"composer":"2.8.8","mysql":"mysql:8.4","opensearch":"opensearchproject/opensearch:2.19.1","rabbitmq":"rabbitmq:4.0-management","redis":"redis:7.2","varnish":"varnish:7.6","nginx":"nginx:1.26","os":"ubuntu-latest","release":"2025-10-16T00:00:00+0000","eol":"2028-10-17T00:00:00+0000"}]}

@rhoerr rhoerr requested a review from a team as a code owner December 13, 2025 21:57
@mage-os-ci mage-os-ci merged commit a41b122 into mage-os:main Dec 13, 2025
53 of 79 checks passed
@rhoerr rhoerr deleted the fix/supported-versions-dist branch December 13, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] supported-versions error on preview build

2 participants