Repository navigation
feat(swarm-scheduler-exporter): expose the one-shot service label - #318
Merged
Merged
Conversation
dargmuesli
force-pushed
the
feat/swarm-scheduler-exporter/one-shot-label
branch
from
October 22, 2026 23:25
ac22a35 to
ec69fb9
Compare
dargmuesli
marked this pull request as ready for review
October 22, 2026 23:30
maevsi-bot
pushed a commit
that referenced
this pull request
Oct 22, 2026
## [21.5.0](21.4.0...21.5.0) (2026-10-22) ### Features * **swarm-scheduler-exporter:** expose the one-shot service label ([#318](#318)) ([7a639b0](7a639b0))
|
🎉 This PR is included in version 21.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The per service replica gap rule, which compares running replicas against schedulable replicas, has to skip services that run to completion and then idle, because from the scheduler's view they sit at 0 of 1. The exporter already suppresses services whose restart policy is none, but the one-shot tasks in this stack use on-failure, so they stay visible, and the rule has to exclude them by name, a list that grows with every new one-shot and fires on a completed job whenever a name is forgotten.
This marks the one-shot services with a
vibetype.one-shotlabel and starts the exporter with the matching-labelflag. Every service level metric then carries avibetype_one_shotlabel,truefor the marked services and empty for the rest, so the rule can exclude on the label instead of on names, and a future one-shot only needs the label. Marked in this change:redpanda-cluster-config,debezium-postgres-connector,reccoom-migration,sqitch, andzammad-init.