Added a null check to setCapInsets, updated build.gradle file - #20
Open
yurykorzun wants to merge 3 commits into
Open
Added a null check to setCapInsets, updated build.gradle file#20yurykorzun wants to merge 3 commits into
yurykorzun wants to merge 3 commits into
Conversation
yurykorzun
commented
Mar 25, 2019
yurykorzun
commented
- Added a null check to the setCapInsets method. Usually it's never called before the uri is set, but in one case it happened in reserve and failed with an error. I don't see a reason to not have the check.
- Updated build.gradle file to support external project variables. Updated gradle wrapper version for 0.59 RN support.
Updated from the original repo
…updated gradle version
|
Why not update the reload method to early return? |
Author
|
Can this be merged? |
|
Please merge this, without this fix I was unable to use the library. With this fix, it just works :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.