tftpd_pcre.c: fix build with pcre2 >= 10.43#1
Open
ffontaine wants to merge 1 commit intomadmartin:masterfrom
Open
tftpd_pcre.c: fix build with pcre2 >= 10.43#1ffontaine wants to merge 1 commit intomadmartin:masterfrom
ffontaine wants to merge 1 commit intomadmartin:masterfrom
Conversation
Fix the following build failure raised since pcre2 >= 10.43 and PCRE2Project/pcre2@014c82d: tftpd_pcre.c: In function 'tftpd_pcre_open': tftpd_pcre.c:109:37: error: passing argument 1 of 'pcre2_substring_list_free_8' from incompatible pointer type [-Wincompatible-pointer-types] 109 | pcre2_substring_list_free((const PCRE2_UCHAR **)substrlist); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | const PCRE2_UCHAR8 ** {aka const unsigned char **} In file included from tftpd_pcre.h:24, from tftpd_pcre.c:35: /home/autobuild/autobuild/instance-10/output-1/host/powerpc64le-buildroot-linux-gnu/sysroot/usr/include/pcre2.h:949:1: note: expected 'PCRE2_UCHAR8 **' {aka 'unsigned char **'} but argument is of type 'const PCRE2_UCHAR8 **' {aka 'const unsigned char **'} 949 | PCRE2_TYPES_STRUCTURES_AND_FUNCTIONS | ^ Fixes: - http://autobuild.buildroot.org/results/46565c834a8162a651944885104027610a65f9c3 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the following build failure raised since pcre2 >= 10.43 and PCRE2Project/pcre2@014c82d:
Fixes: