gzwrite: bound pending input after a non-blocking stall - #1317
Closed
thesmartshadow wants to merge 1 commit into
Closed
thesmartshadow wants to merge 1 commit into
thesmartshadow wants to merge 1 commit into
Conversation
Owner
|
Thanks. Fixed. df84af2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses CVE-2026-85091.
A non-blocking
gzwrite()can leave more thanstate->sizebytespending while
strm->next_instill refers to caller-owned input.gz_vacate()compacts that input intostate->inbeforegzprintf()uses the buffer again. It currently does so without requiring the
pending input to fit in the first half of the internal buffer.
Do not compact pending input unless it fits in
state->size. If thewrite is still stalled with more input pending, return
Z_BUF_ERRORfrom
gzprintf()instead of continuing with an invalid buffer layout.Add a regression test using a full non-blocking pipe, a small
gzbuffer(), a large incompressiblegzwrite(), and a followinggzprintf()call.The test reports a heap-buffer-overflow in
gz_vacate()on v1.3.2 withASan. It passes with this change, as do the normal test suite and an
ASan/UBSan build.
Fixes #1310.