Avoid overflow after a stalled gzprintf write. - #1304
Open
samuelgirmametaferia wants to merge 1 commit into
Open
Avoid overflow after a stalled gzprintf write.#1304samuelgirmametaferia wants to merge 1 commit into
samuelgirmametaferia wants to merge 1 commit into
Conversation
Author
|
Hey could you please review this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an overflow in the buffered
gzwrite()path after a non-blockinggzprintf()stalls with more thanstate->sizebytes pending in the double-sized input buffer.Previously, the small-write path computed
state->size - havewithout first handlinghave >= state->size, so the subtraction could underflow and lead to a copy past the input allocation. The fix first attempts to drain the pending input withgz_comp()and returns the non-blocking stall without consuming caller input when the output cannot make progress.A focused regression test fills a non-blocking pipe, uses a small gzip buffer, performs two
gzprintf()calls to reach the stalled state, and verifies that a followinggzwrite()consumes no input.Validation performed locally:
zlib_gzprintfwritetest;