Skip to content

Fix memory leak in minizip's zipOpen3 function #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amarkowski999 wants to merge 1 commit into
base: develop
Choose a base branch
from
+6 −0
Open

Fix memory leak in minizip's zipOpen3 function #1291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions contrib/minizip/zip.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1055,6 +1055,11 @@ local int LoadCentralDirectoryRecord(zip64_internal* pziinit) {
if (ZSEEK64(pziinit->z_filefunc, pziinit->filestream, offset_central_dir+byte_before_the_zipfile,ZLIB_FILEFUNC_SEEK_SET) != 0)
err=ZIP_ERRNO;

if (err != ZIP_OK)
{
ZCLOSE64(pziinit->z_filefunc, pziinit->filestream);
}

return err;
}

Expand Down Expand Up @@ -1123,6 +1128,7 @@ extern zipFile ZEXPORT zipOpen3(const void *pathname, int append, zipcharpc* glo
{
# ifndef NO_ADDFILEINEXISTINGZIP
free(ziinit.globalcomment);
free_linkedlist(&(ziinit.central_dir));
# endif /* !NO_ADDFILEINEXISTINGZIP*/
free(zi);
return NULL;
Expand Down