Handle Redis Deprecations by johnsyweb · Pull Request #2 · madlep/fresh_redis

johnsyweb · 2022-04-29T02:27:32Z

Context

Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0, which means apps using this gem are spewing logs like this:

Example logs

Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0.

redis.pipelined do
  redis.get("key")
end

should be replaced by

redis.pipelined do |pipeline|
  pipeline.get("key")
end

(called from /Users/paj/.asdf/installs/ruby/2.7.5/lib/ruby/gems/2.7.0/gems/fresh_redis-0.1.0/lib/fresh_redis/string.rb:33:in `fsum'}
Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0.

redis.pipelined do
  redis.get("key")
end

should be replaced by

redis.pipelined do |pipeline|
  pipeline.get("key")
end

(called from /Users/paj/.asdf/installs/ruby/2.7.5/lib/ruby/gems/2.7.0/gems/fresh_redis-0.1.0/lib/fresh_redis/string.rb:33:in `fsum'}
Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0.

redis.multi do
  redis.get("key")
end

should be replaced by

redis.multi do |pipeline|
  pipeline.get("key")
end

(called from /Users/paj/.asdf/installs/ruby/2.7.5/lib/ruby/gems/2.7.0/gems/fresh_redis-0.1.0/lib/fresh_redis/string.rb:5:in `fincrby'}
Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0.

redis.pipelined do
  redis.get("key")
end

should be replaced by

redis.pipelined do |pipeline|
  pipeline.get("key")
end

(called from /Users/paj/.asdf/installs/ruby/2.7.5/lib/ruby/gems/2.7.0/gems/fresh_redis-0.1.0/lib/fresh_redis/string.rb:33:in `fsum'}

Change

Remove incompatible rspec config from project and leave this to the individual
Unlock and update all gem dependencies
Get specs running again
Use Redis#pipelined with block
Use transaction variable with Redis#multi in anticipation of the same happening here

Considerations

A new release would be nice, please!

…ndividual

The version without the block causes exccessive logging since redis/redis-rb#1059

… happening here

johnsyweb · 2022-04-29T02:30:37Z

-    rspec-mocks (2.11.3)
-    thor (0.16.0)
-    timecop (0.5.2)
+    coderay (1.1.3)


coderay

Gem added ⛄

[~~change-log~~, source-code, ~~gem-diff~~]

johnsyweb · 2022-04-29T02:30:40Z

-    thor (0.16.0)
-    timecop (0.5.2)
+    coderay (1.1.3)
+    diff-lcs (1.5.0)


diff-lcs

Minor version upgrade 📈🔶 1.1.3 → 1.5.0

[~~change-log~~, source-code, gem-diff]

Commits

A change of 143 commits. See the full changes on the compare page.

These are the first 10 commits:

(7f6f229) Fix+specs for Diff::LCS::ChangeTypeTests predicates

(652cc33) Merge pull request #8 from ged/master

(86e4e1b) Adding autotestability.

(a341ac7) Major investigation to Diff::LCS bugs.

(2151e20) Starting on a substantial refactoring to fix bugs.

(ba57477) Get rid of useless shebangs.

(8d6dced) Merge pull request #9 from voxik/master

(5e7577b) Updated GPL2 license file (#10).

(0dc22d2) Merge pull request #11 from voxik/license

(77dba95) Fixing warnings in Ruby code.

johnsyweb · 2022-04-29T02:30:43Z

-    timecop (0.5.2)
+    coderay (1.1.3)
+    diff-lcs (1.5.0)
+    ffi (1.15.5)


ffi

Minor version upgrade 📈🔶 1.1.5 → 1.15.5

[change-log, source-code, gem-diff]

🎉 Patched vulnerabilities:

CVE-2018-1000201
ruby-ffi DDL loading issue on Windows OS

CVSS V2: 6.8 high
URL: https://github.com/ffi/ffi/releases/tag/1.9.24

ruby-ffi version 1.9.23 and earlier has a DLL loading issue which can be hijacked on Windows OS, when a Symbol is used as DLL name instead of a String This vulnerability appears to have been fixed in v1.9.24 and later.

johnsyweb · 2022-04-29T02:30:44Z

+    coderay (1.1.3)
+    diff-lcs (1.5.0)
+    ffi (1.15.5)
+    formatador (1.1.0)


formatador

Gem added ⛄

[~~change-log~~, ~~source-code~~, ~~gem-diff~~]

johnsyweb · 2022-04-29T02:30:48Z

+    diff-lcs (1.5.0)
+    ffi (1.15.5)
+    formatador (1.1.0)
+    guard (2.18.0)


guard

Major version upgrade 📈❗ 1.4.0 → 2.18.0

[~~change-log~~, source-code, gem-diff]

Commits

A change of 1218 commits. See the full changes on the compare page.

These are the first 10 commits:

(4cf68a2) Merge pull request #749 from pjump/autoreload

(2817f00) Release 2.12.4

(07f6b13) fix RuboCop offense

(f06f9b2) detect used plugins more accurately

(3fbd489) improve error message when template fails

(54482b7) add TODOs

(09e3f68) update RuboCop in dev

(47d7c15) fix RuboCop offenses and update styleguide

(4590bf2) Merge pull request #752 from guard/improve_plugin_handling

(10ea1da) Release 2.12.5

johnsyweb · 2022-04-29T02:30:50Z

+      pry (>= 0.13.0)
+      shellany (~> 0.0)
+      thor (>= 0.18.1)
+    guard-compat (1.2.1)


guard-compat

Gem added ⛄

[~~change-log~~, ~~source-code~~, ~~gem-diff~~]

johnsyweb · 2022-04-29T02:30:54Z

+      shellany (~> 0.0)
+      thor (>= 0.18.1)
+    guard-compat (1.2.1)
+    guard-rspec (4.7.3)


guard-rspec

Major version upgrade 📈❗ 2.1.0 → 4.7.3

[~~change-log~~, source-code, gem-diff]

Commits

A change of 403 commits. See the full changes on the compare page.

These are the first 10 commits:

(f48c1c5) Warn about deprecated :keep_failed and :focus_on_failed opti…

(96739fc) Fix :focus_on_failed deprecation message

(6d3489c) Add .ruby-version/-gemset to .gitignore

(e092109) Keep only spec paths in KeepingInspector (omit line numbers)

(c27ac21) Merge pull request #217 from 907th/respect_guard_notifier

(7d4de6d) Update rbx on Travis

(3aca6f4) Remove specific rbx version on Travis

(01b688f) Allow failures on jruby and rbx on Travis

(18ceee4) Release 4.1.0

(f3dab54) Notify @thibaudgg only of Travis CI results

johnsyweb · 2022-04-29T02:30:57Z

+      guard (~> 2.1)
+      guard-compat (~> 1.1)
+      rspec (>= 2.99.0, < 4.0)
+    listen (3.7.1)


listen

Major version upgrade 📈❗ 0.5.3 → 3.7.1

[change-log, source-code, gem-diff]

Commits

A change of 1055 commits. See the full changes on the compare page.

These are the first 10 commits:

(f72ba63) avoid gemspec "duplicate dependency" validation error

(0db811a) Merge pull request #384 from guard/workaround_rubygems_spec_…

(befe13c) remove unused spec code

(66d6079) allow stopping when not fully initialized

(9b2d077) add TODO

(8368b87) Merge pull request #383 from guard/fix_state_transition

(1684919) Release 3.1.2

(03c7052) activate JRuby-9.0.5.0 on Travis

(e86dccf) avoid unkillable thread problem on JRuby

(c23ff1c) get JRuby to fail with ENOTDIR like MRI does

johnsyweb · 2022-04-29T02:30:59Z

+    listen (3.7.1)
+      rb-fsevent (~> 0.10, >= 0.10.3)
+      rb-inotify (~> 0.9, >= 0.9.10)
+    lumberjack (1.2.8)


lumberjack

Gem added ⛄

[~~change-log~~, ~~source-code~~, ~~gem-diff~~]

johnsyweb · 2022-04-29T02:31:01Z

+      rb-fsevent (~> 0.10, >= 0.10.3)
+      rb-inotify (~> 0.9, >= 0.9.10)
+    lumberjack (1.2.8)
+    method_source (1.0.0)


method_source

Gem added ⛄

[~~change-log~~, source-code, ~~gem-diff~~]

johnsyweb · 2022-04-29T02:31:05Z

+      rb-inotify (~> 0.9, >= 0.9.10)
+    lumberjack (1.2.8)
+    method_source (1.0.0)
+    mock_redis (0.31.0)


mock_redis

Minor version upgrade 📈🔶 0.5.4 → 0.31.0

[~~change-log~~, ~~source-code~~, gem-diff]

Commits

A change of 406 commits. See the full changes on the compare page.

These are the first 10 commits:

(f384aca) Enforce numeric literals separated with underscores

(411aa7b) Remove unnecessary blank lines

(c910cc0) Enforce spaces after commas

(0e3f8e1) Enforce spaces around equals in parameter defaults

(7fd09d6) Prefer empty literals

(ba85b62) Remove unnecessary begin blocks

(024b40c) Indent when statements at same level as case

(7656262) Add specific errors to raise_error expectation

(a64361a) Fix literal in interpolation

(2027e58) Remove unnecessary method call parentheses

johnsyweb · 2022-04-29T02:31:06Z

+    method_source (1.0.0)
+    mock_redis (0.31.0)
+      ruby2_keywords
+    nenv (0.3.0)


nenv

Gem added ⛄

[~~change-log~~, ~~source-code~~, ~~gem-diff~~]

johnsyweb · 2022-04-29T02:31:08Z

+    mock_redis (0.31.0)
+      ruby2_keywords
+    nenv (0.3.0)
+    notiffany (0.1.3)


notiffany

Gem added ⛄

[~~change-log~~, source-code, ~~gem-diff~~]

johnsyweb · 2022-04-29T02:31:10Z

+    notiffany (0.1.3)
+      nenv (~> 0.1)
+      shellany (~> 0.0)
+    pry (0.14.1)


pry

Gem added ⛄

[change-log, source-code, ~~gem-diff~~]

johnsyweb · 2022-04-29T02:31:14Z

GHSA-jppv-gw3r-w3q8

+    pry (0.14.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    rake (13.0.6)


rake

Major version upgrade 📈❗ 0.9.2.2 → 13.0.6

[change-log, source-code, gem-diff]

🎉 Patched vulnerabilities:

CVE-2020-8130
OS Command Injection in Rake

CVSS V2: 9.3 high
URL: GHSA-jppv-gw3r-w3q8

There is an OS command injection vulnerability in Ruby Rake < 12.3.3 in Rake::FileList when supplying a filename that begins with the pipe character |.

Commits

A change of 1443 commits. See the full changes on the compare page.

These are the first 10 commits:

(82467f1) rubocop -a

(972c9ce) History

(f543024) bump release version to 12.1.0

(3d6df97) Fixed release date #222.

(d183f4d) Fix typo

(cff33d7) Merge pull request #223 from znz/fix-typo

(32dcaa6) Merge pull request #211 from ruby/drbrain/rake-as-library

(7356091) fixed warnings

(9ee9f69) Merge pull request #226 from walf443/fix_ambiguous_warning

(02fbc5c) Removed _JAVA_OPTIONS for JRuby task

johnsyweb · 2022-04-29T02:31:18Z

+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    rake (13.0.6)
+    rb-fsevent (0.11.1)


rb-fsevent

Minor version upgrade 📈🔶 0.9.2 → 0.11.1

[~~change-log~~, source-code, gem-diff]

Commits

A change of 93 commits. See the full changes on the compare page.

These are the first 10 commits:

(a80be21) Update README.rdoc

(6334971) Most of these changes were made many months ago and never co…

(d9481b5) change default build deployment target to 10.6

(75f1b9c) Handle potential race condition when stopping

(fa8ad08) Merge pull request #40 from rubinius/master

(1ddd3df) remove xcode project, replace with rakefile. xcodebuild stil…

(6d66f2e) 1.8 makes me grumpy

(a942a09) rebuild fsevent_watch pre-compiled binary on a 32bit imac wh…

(4cf18f4) update README

(f62d127) various tweaks

johnsyweb · 2022-04-29T02:31:21Z

+      method_source (~> 1.0)
+    rake (13.0.6)
+    rb-fsevent (0.11.1)
+    rb-inotify (0.10.1)


rb-inotify

Minor version upgrade 📈🔶 0.8.8 → 0.10.1

[~~change-log~~, ~~source-code~~, gem-diff]

Commits

A change of 102 commits. See the full changes on the compare page.

These are the first 10 commits:

(3488a84) Use more durable FFI::Library::LIBC constant.

(3255dca) Merge pull request #20 from mbj/master

(f25e18e) Expose Notifier.read_events.

(aca1714) Update lib/rb-inotify/notifier.rb

(28b1f51) Merge pull request #22 from geoffyoungs/patch-1

(c90466d) Merge branch 'master' of github.com:nex3/rb-inotify

(c9ed1f1) Version bump to 0.9.0

(6a8f19c) Regenerate gemspec for version 0.9.0

(536d1c1) Rename conflict variable with the following block

(f74b12f) Merge pull request #24 from kachick/improve-remove_warnings

johnsyweb · 2022-04-29T02:31:24Z

+    rb-fsevent (0.11.1)
+    rb-inotify (0.10.1)
+      ffi (~> 1.0)
+    redis (4.6.0)


redis

Major version upgrade 📈❗ 3.2.0 → 4.6.0

[change-log, source-code, gem-diff]

Commits

A change of 673 commits. See the full changes on the compare page.

These are the first 10 commits:

(0559b50) Fix Sentinel authentication and resolve #855

(d21527d) Merge pull request #856 from supercaracal/fix-sentinel-auth

(cc6eadf) Fix a typo

(a060e8c) Update rubygems version

(f4fd4f7) Merge pull request #857 from supercaracal/fix-a-typo

(331fadc) Merge pull request #858 from supercaracal/update-rubygems-ve…

(d6a2fd5) Use nonblocking IO for SSL socket connect.

(9101933) Release 4.1.2

(5c6ca51) Reduce timeout for ssl test

(38f2b07) Add "See Also" section to README.

johnsyweb · 2022-04-29T02:31:27Z

+    rb-inotify (0.10.1)
+      ffi (~> 1.0)
+    redis (4.6.0)
+    rspec (3.11.0)


rspec

Major version upgrade 📈❗ 2.11.0 → 3.11.0

[~~change-log~~, source-code, gem-diff]

Commits

A change of 94 commits. See the full changes on the compare page.

These are the first 10 commits:

(b8e9f83) bump version to 2.12

(3fdda41) 2.13.0 release

(be31e37) Uses secure RubyGems URL

(69994d0) Merge pull request #2 from vfrride/patch-1

(4d279d8) Release 2.14.0.rc1

(047df66) Release 2.14.0

(a3daf2b) This branch is 3.0.0.pre now

(f10bedd) Don't explicitly require mocks and expectations upfront.

(90e3db8) Update gem spec.

(07c4132) Uses rspec-support from the local dev directory

johnsyweb · 2022-04-29T02:31:31Z

+      rspec-core (~> 3.11.0)
+      rspec-expectations (~> 3.11.0)
+      rspec-mocks (~> 3.11.0)
+    rspec-core (3.11.0)


rspec-core

Major version upgrade 📈❗ 2.11.1 → 3.11.0

[change-log, source-code, gem-diff]

Commits

A change of 3788 commits. See the full changes on the compare page.

These are the first 10 commits:

(e894c64) Fix treatment of rake task option as an Array.

(50e9c7f) Merge pull request #2704 from marcandre/rspec_opt_array

(002ebcb) Changelog for #2704

(a5a6a26) Add information about hook defaults to cucumber scenario

(dd3b2ab) Merge pull request #2708 from rspec/add-default-hook-docs

(5e0b12d) Updated travis build scripts (from rspec-dev)

(464b848) Merge pull request #2709 from rspec/update-travis-build-scri…

(0672a8e) Updated travis build scripts (from rspec-dev)

(73c27f4) Merge pull request #2714 from rspec/update-travis-build-scri…

(6a5d667) Add scenario explaining example failures do not affect hooks

johnsyweb · 2022-04-29T02:31:35Z

+      rspec-mocks (~> 3.11.0)
+    rspec-core (3.11.0)
+      rspec-support (~> 3.11.0)
+    rspec-expectations (3.11.0)


rspec-expectations

Major version upgrade 📈❗ 2.11.3 → 3.11.0

[change-log, source-code, gem-diff]

Commits

A change of 1969 commits. See the full changes on the compare page.

These are the first 10 commits:

(76ed5cf) Bump version to 3.9.0.pre.

(3a0b5e4) call to_hash only when object is not a Hash in RSpec::Matche…

(31f108e) Forwardport 3.8.1 release notes.

(2c19f38) Support checking initialize when checking respond_to(:new)

(e20fcac) Merge pull request #1072 from rspec/respond_to_checks_initia…

(8947285) Update changelog for #1072

(06fca6b) Updated travis build scripts (from rspec-dev)

(81b6039) Prevent Github vulnerability warning

(4e8af84) Merge pull request #1073 from jkowens/3-8-maintenance

(66a9fa4) Changelog for #1073

johnsyweb · 2022-04-29T02:31:39Z

+    rspec-expectations (3.11.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.11.0)
+    rspec-mocks (3.11.1)


rspec-mocks

Major version upgrade 📈❗ 2.11.3 → 3.11.1

[change-log, source-code, gem-diff]

Commits

A change of 2040 commits. See the full changes on the compare page.

These are the first 10 commits:

(4847ef0) Changelog for #1167.

(d8e2d47) Update README.md (#1169)

(0820af7) Updated travis build scripts (from rspec-dev) (#1172)

(2f64278) Updated travis build scripts (from rspec-dev)

(8b010b7) Merge pull request #1174 from rspec/update-travis-build-scri…

(fa91024) Updated travis build scripts (from rspec-dev)

(297dd60) Mark a pending example on JRuby 9000 fixed

(78d04f0) Merge pull request #1180 from rspec/update-travis-build-scri…

(7b8bb80) Updates changelog for v3.7.0 [ci skip]

(df6ce2c) Releases 3.7.0

johnsyweb · 2022-04-29T02:31:41Z

+    rspec-mocks (3.11.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.11.0)
+    rspec-support (3.11.0)


rspec-support

Gem added ⛄

[change-log, source-code, ~~gem-diff~~]

johnsyweb · 2022-04-29T02:31:43Z

+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.11.0)
+    rspec-support (3.11.0)
+    ruby2_keywords (0.0.5)


ruby2_keywords

Gem added ⛄

[~~change-log~~, ~~source-code~~, ~~gem-diff~~]

johnsyweb · 2022-04-29T02:31:45Z

+      rspec-support (~> 3.11.0)
+    rspec-support (3.11.0)
+    ruby2_keywords (0.0.5)
+    shellany (0.0.1)


shellany

Gem added ⛄

[~~change-log~~, ~~source-code~~, ~~gem-diff~~]

johnsyweb · 2022-04-29T02:31:49Z

+    rspec-support (3.11.0)
+    ruby2_keywords (0.0.5)
+    shellany (0.0.1)
+    thor (1.2.1)


thor

Major version upgrade 📈❗ 0.16.0 → 1.2.1

[change-log, source-code, gem-diff]

Commits

A change of 712 commits. See the full changes on the compare page.

These are the first 10 commits:

(1e1d85d) Fix incorrect use of Process::exit. This fixes open issue #2…

(2644b85) lock hashdiff to <0.3.6 to fix travis

(cb3bb7d) update ruby version in travis config

(5c4388e) Merge pull request #583 from lostapathy/fix_travis

(61d4866) Merge pull request #584 from lostapathy/bump_travis_versions

(16a075e) Fixed misspelling words.

(0e2615f) Merge pull request #586 from hsbt/fix-misspell

(713dbb6) Use correct line numbers for class_eval and module_eval …

(70021d0) Deprecate safe_level of ERB.new in Ruby 2.6

(47d7440) Address #595 by duplicating string objects

johnsyweb · 2022-04-29T02:31:52Z

+    ruby2_keywords (0.0.5)
+    shellany (0.0.1)
+    thor (1.2.1)
+    timecop (0.9.5)


timecop

Minor version upgrade 📈🔶 0.5.2 → 0.9.5

[~~change-log~~, source-code, gem-diff]

Commits

A change of 278 commits. See the full changes on the compare page.

These are the first 10 commits:

(a7a98ac) Merge pull request #69 from jordimassaguerpla/master

(0d6c58f) fix typo

(c3b466a) Refactor tests so order doesn't matter.

(bf5d377) ActiveSupport::TimeWithZone#to_r is broken, which

(da2943b) Refactor initial parsing of frozen time, add a test

(0dc15bc) Fix bug with timezones losing info on freeze and travel

(8c4df10) Merge pull request #73 from tommeier/master

(b86f633) v0.6.0

(ef849ff) Check Time.zone isn't nil

(ff8b96e) Merge pull request #74 from hamakn/check_time_zone

benlangfeld · 2023-01-18T21:13:48Z

@madlep Might you consider this PR?

johnsyweb added 5 commits April 29, 2022 11:35

Remove incompatible rspec config from project and leave this to the i…

3e6d0c8

…ndividual

Unlock and update all gem dependencies

86474fc

Get specs running again

cd9c855

Use Redis#pipelined with block

a900beb

The version without the block causes exccessive logging since redis/redis-rb#1059

Use transaction variable with Redis#multi in anticipation of the same…

8da9b69

… happening here

johnsyweb commented Apr 29, 2022

View reviewed changes

johnsyweb force-pushed the paj/fix-deprecation-warnings branch from b0d00c0 to 8da9b69 Compare May 20, 2022 04:23

johnsyweb mentioned this pull request May 20, 2022

Fix deprecation warnings envato-archive/fresh_redis#1

Merged

benlangfeld approved these changes Jan 18, 2023

View reviewed changes

Conversation

johnsyweb commented Apr 29, 2022

Context

Change

Considerations

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

benlangfeld commented Jan 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants