Repository navigation
gterm: fix SSH, LLM, and persistence defects from audit - #40
Merged
Merged
Conversation
Reject invalid LLM provider URLs instead of sending keys to OpenAI, keep completion suffixes and command sanitizer output intact, skip unusable SSH keys, and drop session/port-forward work that races past stop. Filter obvious secrets from command history and reject out-of-range SSH ports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First-party audit of SSH/auth, Keychain/persistence, LLM completion/command sanitizer, and session lifecycle. Fixes correctness, security, and reliability defects found there:
api.openai.com.stoppedon the main queue so a queued.connectedcannot stick the UI after disconnect.stopAll()wins the race.passwd/sshpass/ secret assignments; SSH ports must be 1–65535.Test plan
xcodegen generate && xcodebuild -project gterm.xcodeproj -scheme gtermTests -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone 17' test— 82 tests, TEST SUCCEEDEDxcodebuild -project gterm.xcodeproj -scheme gterm -sdk iphonesimulator -destination 'generic/platform=iOS Simulator' CODE_SIGNING_ALLOWED=NO build— BUILD SUCCEEDED