Repository navigation
gterm: dismiss the terminal when the remote closes the session - #39
Merged
Merged
Conversation
Add a hide-keyboard button fixed at the trailing edge of the accessory bar (always reachable regardless of scroll position) and a keyboard toggle in the terminal status bar. Collapsing resigns first responder, dismissing both the software keyboard and the accessory bar; tapping the terminal or the status-bar button expands it again. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
When the shell exits cleanly (e.g. typing exit), the PTY channel goes inactive and SSHSession reports .closed — auto-dismiss the terminal screen instead of leaving a dead surface up. Failures still keep the screen visible so the error message stays readable. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Rebase onto main left the old TerminalScreen locals (`state`, `terminalView`) in place; the screen now reads them from the session-owned surface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exit), the terminal screen now dismisses instead of leaving a dead surface up. Failures still keep the screen visible so the error stays readable.onCloseprunes the deadActiveSessionand returns to the Hosts list.Testing
xcodebuild -scheme gtermTests -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone 17' test— TEST SUCCEEDED (45 tests)xcodebuild -scheme gterm -sdk iphonesimulator -destination 'generic/platform=iOS Simulator' build— BUILD SUCCEEDED