Open
Conversation
r0skar
reviewed
Apr 2, 2024
Contributor
r0skar
left a comment
r0skar
left a comment
There was a problem hiding this comment.
Not sure about this one - iE. I dont think it make sense to add a new dependency (dev or not) for a feature that we rarely use. Let's just remove the export command? If a projects needs a static export - usually its a custom thing anyway and it should be setup on a project level. What do you think?
Contributor
Author
|
Yeah I agree, let's just remove the command. I updated the PR. |
r0skar
approved these changes
Apr 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
next exporthas been removed and it's not a valid command anymore.The correct way to get a static export is now by setting
output: "export"in thenext.configfile.I added an env variable to control this behaviour, otherwise if
outputis set to "export" it will always create a static export whennext buildruns.Usually for us, we run the normal next app on a server, where we don't need the site to be a static export there.
https://nextjs.org/docs/pages/building-your-application/deploying/static-exports