fix(gpui): make Windows startup reliable - #82
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (16)
📝 WalkthroughWalkthroughThe change adds pinned dependency submodules, updates GPUI and release paths, adds a WSL2 Windows build script, extends startup handling to WSL2, centralizes process termination, translates Windows project paths to WSL paths, and ties application shutdown to the main window. ChangesGPUI dependency and build integration
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Developer
participant startGpui as start-gpui.mjs
participant WSLBuild as build-windows-app-wsl.sh
participant WindowsTools as Windows Cargo and cmd.exe
participant Staging
Developer->>startGpui: start GPUI on Windows or WSL2
startGpui->>WSLBuild: select Windows build script
WSLBuild->>WindowsTools: build release Windows binaries
WindowsTools->>Staging: produce application binaries
WSLBuild->>Staging: copy CEF, locales, assets, and runtime archives
Possibly related PRs
Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.45.0)gpui/src/main.rsast-grep timed out on this file Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
bun run startunder WSL without PowerShell.dependenciessubmodules while preserving the checked-in compatibility patch contractVerification
E:\dev\ghostex\gpui\build\windows\Ghostex\Ghostex.exeE:\dev\ghostex, observed the modal close successfully, and confirmed gxserver stored/mnt/e/dev/ghostexZed::WindowandGhostex Sidebartargets; the CEF panic log stayed at its six pre-fix entriescargo +1.95.0 check --manifest-path gpui/Cargo.toml --bin ghostex-gpuiGPUI tests were not added or run per the repository instructions.
Summary by CodeRabbit
New Features
Bug Fixes