Skip to content

Jumping animation on MacosScaffold Toolbar when toggling Sidebar #569

Open

Description

@Jannik-Hm

Description

When using the ToolBar in a MacosScaffold, on Sidebar toggle, the toolbar jumps around.
This is a result of the animation being performed by MacosWindow on the entire MacosScaffold.

Steps To Reproduce

  1. Execute a macos_ui app
  2. toggle sidebar

Expected behavior

This animation should be happening without weird jumping artifacts.

For a proper solution the animation of the toolbar would need to be decoupled from the content area animation in the main window as it is currently in line 378 ff. in layout/window.dart.

Any ideas?

Activity

  1. Adrian-Samoticha commented on Apr 13, 2025

    @Adrian-Samoticha
    Member

    Would you mind recording a video of that happening just so weʼre on the same page on what the issue is?

  2. Jannik-Hm commented on Apr 13, 2025

    @Jannik-Hm
    Author

    Sure, here.
    Basically the animation starts behind the window control buttons, which seems weird.

    Toolbar-Jumping.mov

    It happens quite fast, so it is a bit of a nitpick but still off-throwing to the user.

  3. Jannik-Hm commented on Apr 13, 2025

    @Jannik-Hm
    Author

    Same thing happens when hiding the sidebar again as well. There the Toolbar jumps to the right

  4. Adrian-Samoticha commented on Apr 14, 2025

    @Adrian-Samoticha
    Member

    Oh yeah, I see what you mean. To be honest, on most (all?) native macOS apps, the toolbar button actually stays stationary while the rest of the toolbar shifts. I’d argue that this issue needs a little bit more work than just fixing the animation.

    This issue is related: #507

  5. Jannik-Hm commented on Apr 14, 2025

    @Jannik-Hm
    Author

    Yeah, also saw that.
    Just wanted to note that this jumping also applies to the rest of the toolbar, not just the icon.
    So yeah, the current concept does not work out 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions