Conversation
Discovered loopback servers on a desktop-local environment were rewritten to the connection host. On WSL2 NAT that host is the distro eth0 address, so a dev server bound to 127.0.0.1 never accepts the click. Keep those targets on localhost. Saved remote hosts still open on their own address. Fixes pingdotgg#13444
github-actions
Bot
added
vouch:trusted
Owner
Author
|
Opened upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes pingdotgg#13444
What
Browser panel Local servers and Recently used entries for a desktop-local environment now open
http://localhost:<port>/when the listed server is a loopback service. That includes the WSL2 NAT backend, whose connection URL is the distro eth0 address (172.x).Saved remote and LAN hosts stay as they are. A loopback discovery on a private-network environment that is not desktop-local still opens on that environment's host. A URL that is already a non-loopback host stays on that host.
Why
The desktop WSL backend advertises the distro eth0 IP so the T3 server, which binds
0.0.0.0, stays reachable when wslhost forwarding is flaky. The browser resolver treated every private connection host the same way and rewrote loopback picker URLs onto that IP. A dev server bound only to127.0.0.1never acceptshttp://172.x:<port>/. Windows localhost forwarding acceptshttp://localhost:<port>/, which is why typing the same URL in the address bar already worked.Verification
Observed: Test Files 2 passed (2). Tests 36 passed (36).
Observed:
tsc --noEmitexited 0.Observed: exited 0.
Checklist
No UI chrome change; the navigation target for an existing list click is the only behavior change.
Grok 4.7 via Cursor cloud agent.